[dev] [commits] Horde branch develop updated. b06007e3fb2f80449e5a72039d300ae9ebfb5630

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> Zitat von Michael J Rubinsky <mrubinsk at horde.org>:
>>>
>>>> Quoting Michael J Rubinsky <mrubinsk at horde.org>:
>>>>
>>>>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>>>>
>>>>>> Quoting Jan Schneider <jan at horde.org>:
>>
>> [snip]
>>
>>>>>>> - The labels are no longer vertically centered, but  
>>>>>>> bottom-aligned with the icons.
>>>>>>
>>>>>> I don't see this, at least with FF.
>>>>>
>>>>> I see this too on FF/MacOS
>>>>
>>>> .. and this is due to the vertical-align: sub; rule in the  
>>>> horde-subnavi-icon class. Shouldn't this be middle?
>>>
>>> Yes, that fixes it.
>>
>> Nope, this breaks things again for me.  Text is now aligned almost  
>> to the top of the icon.  See attachment (hopefully image is not  
>> stripped from message).
>
> Which browser is this? Still looks better than bottom alignment in  
> Firefox before that change.

FF 14.0.1, Chrome 21, and IE9.

The problem is with the height of the rows.  We should not be adding  
vertical padding to the icon; we need to adjust the height of the  
entire row instead.  Think the solution I am going to push should work  
for us.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]