[dev] [commits] Horde branch develop updated. 2cd26a26e02a3c15e50c6a7bbf2f59397288f9bf

Michael M Slusarz slusarz at horde.org
Tue Aug 28 22:04:07 UTC 2012


Quoting Jan Schneider <jan at horde.org>:

> commit a1d6e4df3fed121da78ca4a55a7131ac156785f8
> Author: Jan Schneider <jan at horde.org>
> Date:   Tue Aug 28 23:54:10 2012 +0200
>
>     This won't work with some TLDs. Add failing test.
>
>  framework/Mail/test/Horde/Mail/AddressTest.php |   14 +++++++++++++-
>  1 files changed, 13 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/a1d6e4df3fed121da78ca4a55a7131ac156785f8

Your tests are incorrect.  The documentation clearly states that  
base_domain returns the TLD + 1 subdomain level only.

Your tests indicate that base_domain may be of dubious (or no)  
usefulness.  But it is not a failing test.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list