[dev] [commits] Horde branch master updated. 7cad441d80052d72e9bb454b2419f5faa039c329

[Jan Schneider]

Zitat von Michael J Rubinsky <mrubinsk at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>>> commit ebfab3f82ad6a1eb66e63b7639a3335ff1bd4acc
>>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>>> Date:   Fri Sep 28 18:25:26 2012 -0400
>>>
>>>   Fix importing VALARM elements with TRIGGER;VALUE=DATE-TIME attributes.
>>>
>>>   Fixes incorrect calculation of alarm values. This was causing negative
>>>   values to be calculated, which also broke some ActiveSync devices.
>>>
>>> kronolith/lib/Event.php |    3 +++
>>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>>
>>> http://git.horde.org/horde-git/-/commit/ebfab3f82ad6a1eb66e63b7639a3335ff1bd4acc
>>
>> Shouldn't we loop over the parameters in this case? The order can vary.
>
> I had thought there was only ever a single parameter in the TRIGGER  
> case, but I have changed it to loop over the returned parameters,  
> looking for the one we are interested in.

I probably misread the diff then. It looked to me like we were looping  
over all parameters there, i.e. TRIGGER and VALUE.

-- 
Jan Schneider
The Horde Project
http://www.horde.org/