[dev] [commits] Horde branch master updated. fb837364f9d130945aa5973579a9f8b8efcaf819

Jan Schneider jan at horde.org
Mon Oct 8 19:18:34 UTC 2012


> commit fb837364f9d130945aa5973579a9f8b8efcaf819
> Author: Michael M Slusarz <slusarz at horde.org>
> Date:   Mon Oct 8 12:16:06 2012 -0600
>
>     Revert "Set deleted flag after deleting messages (Bug #11362)."
>
>     This reverts commit 0f2825e310ac49283d08a35c2d19d199af5452e5.
>
>     Can't do this, since it does not correctly update the mailbox  
> cache value.
>
>     Regardless, flags should never be set on the browser-side - we need
>     confirmation from the IMAP server that it has been set on the server or
>     else it is a usability nightmare (flag setting MUST be an atomic
>     operation from the POV of the user).
>
>  imp/js/smartmobile.js |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/fb837364f9d130945aa5973579a9f8b8efcaf819

But this is exactly how we do it in the dynamic view, I migrated the  
code from there. The flagging might be reverted if deleteMessages  
fails, but as soon as the request is sent, and for the time being,  
this is how we mark messages deleted in the dynamic view.
-- 
Jan Schneider
The Horde Project
http://www.horde.org/



More information about the dev mailing list