[dev] passwd vs imp auth Re: [commits] Horde branch master updated. f1a9c26a2e5e8b5edf4216f6278426593e4dda69

[Michael M Slusarz]

Quoting Ralf Lang <lang at b1-systems.de>:

>> commit f1a9c26a2e5e8b5edf4216f6278426593e4dda69
>> Author: Ralf Lang <lang at b1-systems.de>
>> Date:   Mon Dec 3 16:32:19 2012 +0200
>>
>>     validate imap object's internal password against imp's auth  
>> credentials in authenticateCallback.
>>     This affects the root cause of #11766, #11789, #10228
>>
>>  imp/lib/Auth.php |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/f1a9c26a2e5e8b5edf4216f6278426593e4dda69
>
> I find this one rather ugly and I would like to have it reviewed by
> somebody with deeper IMP knowledge.

Please revert; this is unacceptable.  As Horde stands right now, there  
is no expectation that this value can change.  Analogy: configuration  
options can't change during a user's session, since the config option  
may be used at login time for initialization tasks.

I believe this has been previously mentioned... but for this to work  
correctly/properly, there needs to be a defined Horde-wide API  
callback that indicates that the authentication credentials have  
changed.  See, e.g., Horde_Registry_Application#changeLanguage().

michael

___________________________________
Michael Slusarz [slusarz at horde.org]