[dev] [commits] Horde branch master updated. b7bbdb4e06c4be1cd594878ff641f25ad80d47b7

Jan Schneider jan at horde.org
Thu Dec 6 13:25:16 UTC 2012


> commit 73653c0e373645c41ce667ace1682799f61a5bd0
> Author: Michael M Slusarz <slusarz at horde.org>
> Date:   Tue Dec 4 19:35:41 2012 -0700
>
>     [mms] Optimizations to IMAP token parser.
>
>     No need to bump API version since Tokenizer is not part of publicly
>     available API interface.
>
>  framework/Imap_Client/lib/Horde/Imap/Client/Socket.php          |    2 +-
>  framework/Imap_Client/lib/Horde/Imap/Client/Tokenize.php        |   
> 203 +------
>  framework/Imap_Client/lib/Horde/Imap/Client/Tokenize/List.php   |   93 +++
>  framework/Imap_Client/lib/Horde/Imap/Client/Tokenize/Master.php |   
> 189 ++++++
>  framework/Imap_Client/package.xml                               |   14 +-
>  framework/Imap_Client/test/Horde/Imap/Client/Stub/Socket.php    |   10 +-
>  framework/Imap_Client/test/Horde/Imap/Client/TokenizeTest.php   |   88 ++-
>  7 files changed, 371 insertions(+), 228 deletions(-)
>  create mode 100644  
> framework/Imap_Client/lib/Horde/Imap/Client/Tokenize/List.php
>  create mode 100644  
> framework/Imap_Client/lib/Horde/Imap/Client/Tokenize/Master.php
>
> http://git.horde.org/horde-git/-/commit/73653c0e373645c41ce667ace1682799f61a5bd0

This is only partially true, because the Tokenize class is store  
serialized in the cache. This API change breaks all installations that  
have cached data.

[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP Fatal  
error:  Cannot instantiate abstract class Horde_Imap_Client_Tokenize  
in /home/jan/horde-develop/framework/Mime/lib/Horde/Mime/Part.php on  
line 2280, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP Stack  
trace:, referer: http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP   1.  
{main}() /home/jan/horde-develop/horde/services/ajax.php:0, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP   2.  
Horde_Core_Ajax_Application->doAction()  
/home/jan/horde-develop/horde/services/ajax.php:56, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP   3.  
call_user_func(array (0 => class IMP_Ajax_Application_Handler_Common {  
protected $_base = class IMP_Ajax_Application { public $mbox = class  
IMP_Mailbox { ... }; public $queue = class IMP_Ajax_Queue { ... };  
public $data = NULL; public $tasks = NULL; protected $_action =  
'viewPort'; protected $_app = 'imp'; protected $_handlers = array  
(...); protected $_vars = class Horde_Variables { ... } }; protected  
$_external = array (); protected $_ignored = array (); protected  
$_readOnly = array () }, 1 => 'viewPort'))  
/home/jan/horde-develop/framework/Core/lib/Horde/Core/Ajax/Application.php:155, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP   4.  
IMP_Ajax_Application_Handler_Common->viewPort()  
/home/jan/horde-develop/framework/Core/lib/Horde/Core/Ajax/Application.php:155, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP   5.  
IMP_Ajax_Application->viewPortData($change = TRUE)  
/home/jan/horde-develop/imp/lib/Ajax/Application/Handler/Common.php:99,  
referer: http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP   6.  
IMP_Ajax_Application_ListMessages->listMessages($args = array  
('change' => TRUE, 'mbox' => 'INBOX', 'applyfilter' => NULL, 'cache'  
=> NULL, 'cacheid' => NULL, 'delhide' => NULL, 'initial' => 1,  
'qsearch' => NULL, 'qsearchfield' => NULL, 'qsearchfilter' => NULL,  
'qsearchflag' => NULL, 'qsearchflagnot' => NULL, 'qsearchmbox' =>  
NULL, 'rangeslice' => NULL, 'sortby' => NULL, 'sortdir' => NULL,  
'after' => 66, 'before' => 44, 'slice_start' => 1, 'slice_end' =>  
111)) /home/jan/horde-develop/imp/lib/Ajax/Application.php:239,  
referer: http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP   7.  
IMP_Ajax_Application_ListMessages->_getOverviewData($mbox = class  
IMP_Mailbox { protected $_cache = array ('n' => array (0 => '.', 2 =>  
'INBOX.', 4 => 1), 'd' => 'Posteingang', 'l' => TRUE, 'ro' => FALSE,  
'a' => 'lrswipkxtea'); protected $_changed = 1; protected $_import =  
NULL; protected $_mbox = 'INBOX' }, $msglist = array (0 => 1, 1 => 2,  
2 => 3, 3 => 4, 4 => 5, 5 => 6, 6 => 7, 7 => 8, 8 => 9, 9 => 10, 10 =>  
11, 11 => 12, 12 => 13, 13 => 14, 14 => 15, 15 => 16, 16 => 17, 17 =>  
18, 18 => 19, 19 => 20, 20 => 21, 21 => 22, 22 => 23, 23 => 24, 24 =>  
25, 25 => 26, 26 => 27, 27 => 28, 28 => 29, 29 => 30, 30 => 31, 31 =>  
32, 32 => 33, 33 => 34, 34 => 35, 35 => 36, 36 => 37, 37 => 38, 38 =>  
39, 39 => 40, 40 => 41, 41 => 42, 42 => 43, 43 => 44, 44 => 45, 45 =>  
46, 46 => 47, 47 => 48, 48 => 49, 49 => 50, 50 => 51, 51 => 52, 52 =>  
53, 53 => 54, 54 => 55, 55 => 56, 56 => 57, 57 => 58, 58 => 59, 59 =>  
60, 60 => 61, 61 => 62, 62 => 63, 63 => 64, 64 => 65, 65 => 66, 66 =>  
67, 67 => 68, 68 => 69, 69 => 70, 70 => 71, 71 => 72, 72 => 73, 73 =>  
74, 74 => 75, 75 => 76, 76 => 77, 77 => 78, 78 => 79, 79 => 80, 80 =>  
81, 81 => 82, 82 => 83, 83 => 84, 84 => 85, 85 => 86, 86 => 87, 87 =>  
88, 88 => 89, 89 => 90, 90 => 91, 91 => 92, 92 => 93, 93 => 94, 94 =>  
95, 95 => 96, 96 => 97, 97 => 98, 98 => 99, 99 => 100, 100 => 101, 101  
=> 102, 102 => 103, 103 => 104, 104 => 105, 105 => 106, 106 => 107,  
107 => 108, 108 => 109, 109 => 110, 110 => 111))  
/home/jan/horde-develop/imp/lib/Ajax/Application/ListMessages.php:395,  
referer: http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP   8.  
IMP_Mailbox_List->getMailboxArray($msgnum = array (0 => 1, 1 => 2, 2  
=> 3, 3 => 4, 4 => 5, 5 => 6, 6 => 7, 7 => 8, 8 => 9, 9 => 10, 10 =>  
11, 11 => 12, 12 => 13, 13 => 14, 14 => 15, 15 => 16, 16 => 17, 17 =>  
18, 18 => 19, 19 => 20, 20 => 21, 21 => 22, 22 => 23, 23 => 24, 24 =>  
25, 25 => 26, 26 => 27, 27 => 28, 28 => 29, 29 => 30, 30 => 31, 31 =>  
32, 32 => 33, 33 => 34, 34 => 35, 35 => 36, 36 => 37, 37 => 38, 38 =>  
39, 39 => 40, 40 => 41, 41 => 42, 42 => 43, 43 => 44, 44 => 45, 45 =>  
46, 46 => 47, 47 => 48, 48 => 49, 49 => 50, 50 => 51, 51 => 52, 52 =>  
53, 53 => 54, 54 => 55, 55 => 56, 56 => 57, 57 => 58, 58 => 59, 59 =>  
60, 60 => 61, 61 => 62, 62 => 63, 63 => 64, 64 => 65, 65 => 66, 66 =>  
67, 67 => 68, 68 => 69, 69 => 70, 70 => 71, 71 => 72, 72 => 73, 73 =>  
74, 74 => 75, 75 => 76, 76 => 77, 77 => 78, 78 => 79, 79 => 80, 80 =>  
81, 81 => 82, 82 => 83, 83 => 84, 84 => 85, 85 => 86, 86 => 87, 87 =>  
88, 88 => 89, 89 => 90, 90 => 91, 91 => 92, 92 => 93, 93 => 94, 94 =>  
95, 95 => 96, 96 => 97, 97 => 98, 98 => 99, 99 => 100, 100 => 101, 101  
=> 102, 102 => 103, 103 => 104, 104 => 105, 105 => 106, 106 => 107,  
107 => 108, 108 => 109, 109 => 110, 110 => 111), $options = array  
('headers' => TRUE, 'type' => '1'))  
/home/jan/horde-develop/imp/lib/Ajax/Application/ListMessages.php:435,  
referer: http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP   9.  
IMP_Imap->fetch('INBOX', class Horde_Imap_Client_Fetch_Query {  
protected $_data = array (9 => TRUE, 10 => TRUE, 12 => TRUE, 13 =>  
TRUE, 8 => array ('imp' => array (...))) }, array ('ids' => class  
Horde_Imap_Client_Ids { public $duplicates = FALSE; protected $_ids =  
array (0 => 302712, 1 => 302711, 2 => 302696, 3 => 302626, 4 =>  
302623, 5 => 302628, 6 => 302625, 7 => 302622, 8 => 302613, 9 =>  
302214, 10 => 300941, 11 => 300549, 12 => 300548, 13 => 299893, 14 =>  
299257, 15 => 299225, 16 => 299175, 17 => 299132, 18 => 298608, 19 =>  
298607, 20 => 298666, 21 => 297810, 22 => 297212, 23 => 297210, 24 =>  
297634, 25 => 297131, 26 => 297362, 27 => 297360, 28 => 297258, 29 =>  
297077, 30 => 297076, 31 => 297075, 32 => 297073, 33 => 297072, 34 =>  
297071, 35 => 297066, 36 => 297057, 37 => 297052, 38 => 297054, 39 =>  
297053, 40 => 297061, 41 => 297059, 42 => 297060, 43 => 297058, 44 =>  
297070, 45 => 297067, 46 => 297064, 47 => 297055, 48 => 297051, 49 =>  
297050, 50 => 297049, 51 => 297048, 52 => 297047, 53 => 297046, 54 =>  
297044, 55 => 297043, 56 => 297040, 57 => 297038, 58 => 297036, 59 =>  
297037, 60 => 297035, 61 => 297034, 62 => 297045, 63 => 297042, 64 =>  
297041, 65 => 297039, 66 => 297032, 67 => 297028, 68 => 297027, 69 =>  
297018, 70 => 297017, 71 => 297010, 72 => 297007, 73 => 297006, 74 =>  
297009, 75 => 296997, 76 => 297019, 77 => 297016, 78 => 297015, 79 =>  
297014, 80 => 297013, 81 => 297005, 82 => 297004, 83 => 297003, 84 =>  
297008, 85 => 297002, 86 => 297001, 87 => 297000, 88 => 296999, 89 =>  
296998, 90 => 296996, 91 => 296995, 92 => 296994, 93 => 296993, 94 =>  
296992, 95 => 296991, 96 => 296990, 97 => 296989, 98 => 296988, 99 =>  
296987, 100 => 296985, 101 => 298151, 102 => 296986, 103 => 296984,  
104 => 296982, 105 => 296981, 106 => 296980, 107 => 296978, 108 =>  
296973, 109 => 296974, 110 => 296972); protected $_sequence = FALSE;  
protected $_sorted = FALSE }))  
/home/jan/horde-develop/imp/lib/Mailbox/List.php:180, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP  10.  
IMP_Imap->__call($method = 'fetch', $params = array (0 => 'INBOX', 1  
=> class Horde_Imap_Client_Fetch_Query { protected $_data = array (9  
=> TRUE, 10 => TRUE, 12 => TRUE, 13 => TRUE, 8 => array (...)) }, 2 =>  
array ('ids' => class Horde_Imap_Client_Ids { public $duplicates =  
FALSE; protected $_ids = array (...); protected $_sequence = FALSE;  
protected $_sorted = FALSE })))  
/home/jan/horde-develop/imp/lib/Mailbox/List.php:180, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP  11.  
call_user_func_array(array (0 => class Horde_Imap_Client_Socket {  },  
1 => 'fetch'), array (0 => class Horde_Imap_Client_Mailbox { protected  
$_utf7imap = NULL; protected $_utf8 = 'INBOX' }, 1 => class  
Horde_Imap_Client_Fetch_Query { protected $_data = array (9 => TRUE,  
10 => TRUE, 12 => TRUE, 13 => TRUE, 8 => array (...)) }, 2 => array  
('ids' => class Horde_Imap_Client_Ids { public $duplicates = FALSE;  
protected $_ids = array (...); protected $_sequence = FALSE; protected  
$_sorted = FALSE }))) /home/jan/horde-develop/imp/lib/Imap.php:388,  
referer: http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP  12.  
Horde_Imap_Client_Base->fetch($mailbox = class  
Horde_Imap_Client_Mailbox { protected $_utf7imap = NULL; protected  
$_utf8 = 'INBOX' }, $query = class Horde_Imap_Client_Fetch_Query {  
protected $_data = array (9 => TRUE, 10 => TRUE, 12 => TRUE, 13 =>  
TRUE, 8 => array ('imp' => array (...))) }, $options = array ('ids' =>  
class Horde_Imap_Client_Ids { public $duplicates = FALSE; protected  
$_ids = array (0 => 302712, 1 => 302711, 2 => 302696, 3 => 302626, 4  
=> 302623, 5 => 302628, 6 => 302625, 7 => 302622, 8 => 302613, 9 =>  
302214, 10 => 300941, 11 => 300549, 12 => 300548, 13 => 299893, 14 =>  
299257, 15 => 299225, 16 => 299175, 17 => 299132, 18 => 298608, 19 =>  
298607, 20 => 298666, 21 => 297810, 22 => 297212, 23 => 297210, 24 =>  
297634, 25 => 297131, 26 => 297362, 27 => 297360, 28 => 297258, 29 =>  
297077, 30 => 297076, 31 => 297075, 32 => 297073, 33 => 297072, 34 =>  
297071, 35 => 297066, 36 => 297057, 37 => 297052, 38 => 297054, 39 =>  
297053, 40 => 297061, 41 => 297059, 42 => 297060, 43 => 297058, 44 =>  
297070, 45 => 297067, 46 => 297064, 47 => 297055, 48 => 297051, 49 =>  
297050, 50 => 297049, 51 => 297048, 52 => 297047, 53 => 297046, 54 =>  
297044, 55 => 297043, 56 => 297040, 57 => 297038, 58 => 297036, 59 =>  
297037, 60 => 297035, 61 => 297034, 62 => 297045, 63 => 297042, 64 =>  
297041, 65 => 297039, 66 => 297032, 67 => 297028, 68 => 297027, 69 =>  
297018, 70 => 297017, 71 => 297010, 72 => 297007, 73 => 297006, 74 =>  
297009, 75 => 296997, 76 => 297019, 77 => 297016, 78 => 297015, 79 =>  
297014, 80 => 297013, 81 => 297005, 82 => 297004, 83 => 297003, 84 =>  
297008, 85 => 297002, 86 => 297001, 87 => 297000, 88 => 296999, 89 =>  
296998, 90 => 296996, 91 => 296995, 92 => 296994, 93 => 296993, 94 =>  
296992, 95 => 296991, 96 => 296990, 97 => 296989, 98 => 296988, 99 =>  
296987, 100 => 296985, 101 => 298151, 102 => 296986, 103 => 296984,  
104 => 296982, 105 => 296981, 106 => 296980, 107 => 296978, 108 =>  
296973, 109 => 296974, 110 => 296972); protected $_sequence = FALSE;  
protected $_sorted = FALSE }))  
/home/jan/horde-develop/imp/lib/Imap.php:388, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP  13.  
Horde_Imap_Client_Cache->get($mailbox = class  
Horde_Imap_Client_Mailbox { protected $_utf7imap = TRUE; protected  
$_utf8 = 'INBOX' }, $uids = array (0 => 302712, 1 => 302711, 2 =>  
302696, 3 => 302626, 4 => 302623, 5 => 302628, 6 => 302625, 7 =>  
302622, 8 => 302613, 9 => 302214, 10 => 300941, 11 => 300549, 12 =>  
300548, 13 => 299893, 14 => 299257, 15 => 299225, 16 => 299175, 17 =>  
299132, 18 => 298608, 19 => 298607, 20 => 298666, 21 => 297810, 22 =>  
297212, 23 => 297210, 24 => 297634, 25 => 297131, 26 => 297362, 27 =>  
297360, 28 => 297258, 29 => 297077, 30 => 297076, 31 => 297075, 32 =>  
297073, 33 => 297072, 34 => 297071, 35 => 297066, 36 => 297057, 37 =>  
297052, 38 => 297054, 39 => 297053, 40 => 297061, 41 => 297059, 42 =>  
297060, 43 => 297058, 44 => 297070, 45 => 297067, 46 => 297064, 47 =>  
297055, 48 => 297051, 49 => 297050, 50 => 297049, 51 => 297048, 52 =>  
297047, 53 => 297046, 54 => 297044, 55 => 297043, 56 => 297040, 57 =>  
297038, 58 => 297036, 59 => 297037, 60 => 297035, 61 => 297034, 62 =>  
297045, 63 => 297042, 64 => 297041, 65 => 297039, 66 => 297032, 67 =>  
297028, 68 => 297027, 69 => 297018, 70 => 297017, 71 => 297010, 72 =>  
297007, 73 => 297006, 74 => 297009, 75 => 296997, 76 => 297019, 77 =>  
297016, 78 => 297015, 79 => 297014, 80 => 297013, 81 => 297005, 82 =>  
297004, 83 => 297003, 84 => 297008, 85 => 297002, 86 => 297001, 87 =>  
297000, 88 => 296999, 89 => 296998, 90 => 296996, 91 => 296995, 92 =>  
296994, 93 => 296993, 94 => 296992, 95 => 296991, 96 => 296990, 97 =>  
296989, 98 => 296988, 99 => 296987, 100 => 296985, 101 => 298151, 102  
=> 296986, 103 => 296984, 104 => 296982, 105 => 296981, 106 => 296980,  
107 => 296978, 108 => 296973, 109 => 296974, 110 => 296972), $fields =  
array (0 => 'HICenv', 1 => 'HICflags', 2 => 'HIChdrs', 3 =>  
'HICsize'), $uidvalid = '968256253')  
/home/jan/horde-develop/framework/Imap_Client/lib/Horde/Imap/Client/Base.php:2539, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP  14.  
unserialize('a:5:{s:8:"HICflags";a:1:{i:0;s:5:"\\\\seen";}s:6:"HICenv";C:31:"Horde_Imap_Client_Data_Envelope":758:...') /home/jan/horde-develop/framework/Imap_Client/lib/Horde/Imap/Client/Cache.php:267, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP  15.  
Horde_Mime_Part->unserialize($data =  
'a:20:{i:0;i:1;i:1;s:4:"text";i:2;s:5:"plain";i:3;s:16:"quoted-printable";i:4;a:1:{i:0;O:26:"Horde_Imap_Client_Tokenize":6:{s:11:"\\000*\\000_current";b:0;s:7:"\\000*\\000_key";b:0;s:10:"\\000*\\000_parent";O:26:"Horde_Imap_Client_Tokenize":6:{s:11:"\\000*\\000_current";N;s:7:"\\000*\\000_key";i:0;s:10:"\\000*\\000_parent";O:26:"Horde_Imap_Client_Tokenize":6:{s:11:"\\000*\\000_current";b:0;s:7:"\\000*\\000_key";b:0;s:10:"\\000*\\000_parent";O:26:"Horde_Imap_Client_Tokenize":6:{s:11:"\\000*\\000_current";r:46;s:7:"\\000*\\000_key"...') /home/jan/horde-develop/framework/Imap_Client/lib/Horde/Imap/Client/Cache.php:267, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox
[Thu Dec 06 14:14:29 2012] [error] [client 192.168.60.116] PHP  16.  
unserialize('a:20:{i:0;i:1;i:1;s:4:"text";i:2;s:5:"plain";i:3;s:16:"quoted-printable";i:4;a:1:{i:0;O:26:"Horde_Imap_Client_Tokenize":6:{s:11:"\\000*\\000_current";b:0;s:7:"\\000*\\000_key";b:0;s:10:"\\000*\\000_parent";O:26:"Horde_Imap_Client_Tokenize":6:{s:11:"\\000*\\000_current";N;s:7:"\\000*\\000_key";i:0;s:10:"\\000*\\000_parent";O:26:"Horde_Imap_Client_Tokenize":6:{s:11:"\\000*\\000_current";b:0;s:7:"\\000*\\000_key";b:0;s:10:"\\000*\\000_parent";O:26:"Horde_Imap_Client_Tokenize":6:{s:11:"\\000*\\000_current";r:46;s:7:"\\000*\\000_key"...') /home/jan/horde-develop/framework/Mime/lib/Horde/Mime/Part.php:2280, referer:  
http://neo.wg.de/headhorde/imp/dynamic.php?page=mailbox

-- 
Jan Schneider
The Horde Project
http://www.horde.org/



More information about the dev mailing list