[dev] [commits] Horde branch master updated. 03da9ed59c80288992a3bd205701b1c820fcaf2f

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>>
>>>> commit 03da9ed59c80288992a3bd205701b1c820fcaf2f
>>>> Author: Michael M Slusarz <slusarz at horde.org>
>>>> Date:   Sun Mar 31 19:37:51 2013 -0600
>>>>
>>>>  Bug #12116: Also need to IDN encode from addresses before sending
>>>>
>>>> framework/Mail/lib/Horde/Mail/Transport.php          |   31  
>>>> ++++++++++++++++
>>>> framework/Mail/lib/Horde/Mail/Transport/Mock.php     |    5 ++-
>>>> framework/Mail/lib/Horde/Mail/Transport/Sendmail.php |   21 +----------
>>>> framework/Mail/lib/Horde/Mail/Transport/Smtp.php     |   19 +++-------
>>>> framework/Mail/lib/Horde/Mail/Transport/Smtpmx.php   |   12 ++-----
>>>> framework/Mail/test/Horde/Mail/SendTest.php          |   34  
>>>> +++++++++++++++---
>>>> 6 files changed, 73 insertions(+), 49 deletions(-)
>>>>
>>>> http://git.horde.org/horde-git/-/commit/03da9ed59c80288992a3bd205701b1c820fcaf2f
>>>
>>> This broke several unit test (and thus probably also production  
>>> code) because the From: header is now required, which wasn't the  
>>> case before.
>>
>> It didn't break any production code since messages are required to  
>> have a From address.   
>> http://tools.ietf.org/html/rfc5322#section-3.6  So sending a  
>> message to a "real" backend - e.g. sendmail, SMTP - without a From  
>> address is going to cause an error.
>>
>> So our unit-tests are incorrectly written (although the Horde_Mail  
>> tests work fine. I wouldn't know about the other packages since  
>> Travis is broken and doesn't provide any details on why a build  
>> fails).
>
> But it provides the output from the complete test suite including  
> the failing tests.

Nope.  For at *least* the last week, if I go to a failing run it loads  
the initial page and then has the loading graphic that NEVER goes  
away.  I've tried with 3 different browsers.  I never see the results  
of the run.

If it's changed in the last day, that is news to me.  But I don't have  
the time to keep checking something like this.  CI is pretty useless  
if you have no confidence it is going to produce relevant results.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]