[dev] [commits] Horde branch FRAMEWORK_5_0 updated. 450bba25ab112a31ff062869971d780fd011f8f5

[Michael M Slusarz]

Quoting Michael J Rubinsky <mrubinsk at horde.org>:

> Quoting Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:
>>
>>> commit 70a25e2194fc5e790cebf3c18491d2a319b70395
>>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>>> Date:   Tue Apr 16 16:54:29 2013 -0400
>>>
>>>   Bug: 12185 Fix bad cherry-pick.
>>>
>>>   Horde_ActiveSync_Device is not present in FRAMEWORK_5_0
>>>
>>> framework/ActiveSync/lib/Horde/ActiveSync/Connector/Importer.php |    3 +--
>>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> http://git.horde.org/horde-git/-/commit/70a25e2194fc5e790cebf3c18491d2a319b70395
>>
>> My question is why are *ANY* framework commits being made to  
>> FRAMEWORK_5_0 at this time.  This doesn't make sense.  Framework  
>> code is not tied to 5.0 (or any other Horde version for that matter).
>
> Sure it is. We are still doing synchronized releases for minor  
> versions. I.e., new features for Horde 5.1. Bug fixes for  
> functionality that exists in FRAMEWORK_5_0 are still being built  
> from FRAMEWORK_5_0.

That's absolutely not how it works though.  Under this reasoning,  
there is no purpose to maintaining separately distributed libraries  
since you want to tie certain versions to certain releases.

> The new features in the ActiveSync code (which will be in ActiveSync  
> 2.4.0), while BC with Horde 5.0, still required substantial changes  
> to the code base and deserve to go through the full release cycle of  
> 5.1 before they are declared stable.

But what does version 2.4 have to do with Horde 5.0?  How is it any  
different than veersion 2.5? Or version 2.10?  Just because version  
2.4.x happened to be released concurrently with Horde 5.0.x doesn't  
mean there is anything special about the combination of those two  
branches.

If release version 2.5 is not stable enough for Horde 5.0, it sure as  
heck isn't stable enough for Horde 5.1 either.  If you are not  
comfortable with the stability with a certain framework package, you  
*must* branch the entire repo into a different package.  This is  
exactly what I had to do with several horde_imap_client releases - I  
was uncertain about the stability, and wanted to release point version  
bugfixes of the library.  But claiming that 2.4 is somehow "connected"  
with FRAMEWORK_5_0 makes no sense.

> Put another way, I'm not going to release ActiveSync 2.4.0 as stable  
> before it has been more widely tested, and I'm not going to hold up  
> bug fixes for the current stable code because of this.

We may not like it, but that's the reality of our current situation.   
Namely: there is no way to coherently produce "branches" of framework  
packages.  That's exactly why I have been tremendously vocal about  
moving off of our current repo layout for at least a year now.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]