[dev] [commits] Horde branch master updated. d9642d7776410243da77d669c457abec3f5959f2

[Chuck Hagenbuch]

Quoting Jan Schneider <jan at horde.org>:

>> -----------------------------------------------------------------------
>>
>> commit f91bcfda7919b13cab4ab668411b3f187ad25a8f
>> Author: Chuck Hagenbuch <chuck at horde.org>
>> Date:   Tue May 14 23:38:32 2013 -0400
>>
>>   Add memcache caching of History info - drastically cuts number of  
>> SQL queries when loading Nag task list, for instance.
>>
>>   Maybe should be reworked to use HashTable now?
>>
>> framework/Core/lib/Horde/Core/Factory/History.php |    8 +++++-
>> framework/History/lib/Horde/History.php           |   30  
>> ++++++++++++++++++++-
>> framework/History/lib/Horde/History/Sql.php       |    3 ++
>> 3 files changed, 39 insertions(+), 2 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/f91bcfda7919b13cab4ab668411b3f187ad25a8f
>
> This should be a generic Horde_Cache instance. And you must bump the  
> minor version, and add a @since tag. Also, Horde_Core can just  
> require that version of Horde_Cache and use the setter  
> unconditionally.

Not sure what the version of Horde_Cache has to do with it? I think  
Michael already made this a generic HashTable instance, which seems  
better to me (wanted to avoid db or file caches here).

>> commit a46957fbe67ec9410758852fb1f797595d837b5e
>> Author: Chuck Hagenbuch <chuck at horde.org>
>> Date:   Tue May 14 23:40:23 2013 -0400
>>
>>   This specifically needs to be a string, not just not false
>>
>> framework/Cache/lib/Horde/Cache.php |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/a46957fbe67ec9410758852fb1f797595d837b5e
>
> What about integers?

Dunno - I was going by the error message on decompression.

>> commit d9642d7776410243da77d669c457abec3f5959f2
>> Author: Chuck Hagenbuch <chuck at horde.org>
>> Date:   Tue May 14 23:40:36 2013 -0400
>>
>>   Handle being passed 'memcache' or 'hashtable'
>>
>> framework/Cache/lib/Horde/Cache/Storage/Memcache.php |    6 +++++-
>> 1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/d9642d7776410243da77d669c457abec3f5959f2
>
> This shouldn't happen. Any code that knows about HashTable and still  
> uses Memcache should map the parameter names. What's the calling  
> code that made this necessary?

The Horde_Cache factory, I believe.

-chuck

-chuck