[dev] [commits] Horde branch master updated. 33de0814d5219ec08d439950e86d24140c4829f0

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> commit 33de0814d5219ec08d439950e86d24140c4829f0
> Author: Jan Schneider <jan at horde.org>
> Date:   Tue May 28 23:59:18 2013 +0200
>
>     Revert "Set Ingo supportShares default to false"
>
>     This reverts commit c8c192b681dceda3b20a8557b83a0126df14b9ee.
>
>     This would always evaluate to false.
>
>  ingo/docs/CHANGES        |    2 --
>  ingo/lib/Application.php |    2 +-
>  ingo/package.xml         |    2 --
>  3 files changed, 1 insertions(+), 5 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/33de0814d5219ec08d439950e86d24140c4829f0

I apologize - I got my &= logic backward.

But that being said: this still isn't correct.  Given multiple backend  
transports, one false response for share support for a transport will  
cause NO shares to be created.  That's obviously broken also.

Not to mention, this code is being run EVERY TIME ingo is accessed.   
That is almost certainly not necessary either.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]