[dev] [commits] Horde branch master updated. 07cfacb52b173d953835dc2388a32cd8e86a2ae5

[Michael M Slusarz]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> commit 07cfacb52b173d953835dc2388a32cd8e86a2ae5
>> Author: Jan Schneider <jan at horde.org>
>> Date:   Tue Aug 6 14:39:20 2013 +0200
>>
>>    Revert "Silence errors if autoloader cache file does not exist"
>>
>>    This is intentionally not silenced to get notification about permission
>>    problems etc.
>>
>>    This reverts commit 9dbf7468cb8c28d7fcc4eaf95b16a030f4e63880.
>>
>> framework/Autoloader_Cache/lib/Horde/Autoloader/Cache.php |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/07cfacb52b173d953835dc2388a32cd8e86a2ae5
>
> ...except this doesn't work for the initial attempt when there is no  
> cache (an error message is output).

Also... if temp files can't be created/accessed in the system/PHP  
defined temporary directory, you have MANY more problems than just the  
Autoloader_Cache.  All sorts of things aren't going to be working.

Instead, how about trying to unlink the file if file_get_contents()  
fails.  If THAT fails, then we can issue a warning.  This is the only  
case we care about here - if the file exists and we can't access it.


The case of no access at all to the directory should be handled at the  
file_put_contents() time.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]