[dev] [commits] Horde branch master updated. deb0a777eb8ccdd6b7ebe7bdd6dbc1bb7853206c

[Michael J Rubinsky]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:
>
>> commit deb0a777eb8ccdd6b7ebe7bdd6dbc1bb7853206c
>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>> Date:   Mon Jan 13 11:01:28 2014 -0500
>>
>>    The autocompleter requires hordecore.js.
>>
>>    Fixes js errors in standard view kronolith.
>>
>> framework/Core/lib/Horde/Core/Ajax/Imple/AutoCompleter.php |    1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> http://github.com/horde/horde/commit/deb0a777eb8ccdd6b7ebe7bdd6dbc1bb7853206c
>> http://git.horde.org/horde-git/-/commit/deb0a777eb8ccdd6b7ebe7bdd6dbc1bb7853206c
>
> This is incorrect.  We never load hordecore from a JS component  
> library - this needs to be loaded at the base page level (i.e.  
> Horde_PageOutput).
>
> If hordecore.js is not loading on the base page, it needs to be  
> fixed there (see, e.g., IMP's basic page views such as  
> lib/Basic/Mailbox.php).

I'll change it if that's the H5 paradigm, but it seems to me that this  
requirea the application code to know internal information about the  
library code. Shouldn't this be somehow encapsulated in the library  
code?
-- 
mike

The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5849 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/dev/attachments/20140113/9ea56349/attachment.bin>