[dev] [commits] Horde branch master updated. deb0a777eb8ccdd6b7ebe7bdd6dbc1bb7853206c

[Michael M Slusarz]

Quoting Michael J Rubinsky <mrubinsk at horde.org>:

> Quoting Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:
>>
>>> commit deb0a777eb8ccdd6b7ebe7bdd6dbc1bb7853206c
>>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>>> Date:   Mon Jan 13 11:01:28 2014 -0500
>>>
>>>   The autocompleter requires hordecore.js.
>>>
>>>   Fixes js errors in standard view kronolith.
>>>
>>> framework/Core/lib/Horde/Core/Ajax/Imple/AutoCompleter.php |    1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> http://github.com/horde/horde/commit/deb0a777eb8ccdd6b7ebe7bdd6dbc1bb7853206c
>>> http://git.horde.org/horde-git/-/commit/deb0a777eb8ccdd6b7ebe7bdd6dbc1bb7853206c
>>
>> This is incorrect.  We never load hordecore from a JS component  
>> library - this needs to be loaded at the base page level (i.e.  
>> Horde_PageOutput).
>>
>> If hordecore.js is not loading on the base page, it needs to be  
>> fixed there (see, e.g., IMP's basic page views such as  
>> lib/Basic/Mailbox.php).
>
> I'll change it if that's the H5 paradigm, but it seems to me that  
> this requirea the application code to know internal information  
> about the library code. Shouldn't this be somehow encapsulated in  
> the library code?

Not as written in H5.  To use any PHP JS loading code in Horde  
requires HordeCore (or its smartmobile equivalent) to be present.  It  
is needed for correct code loading order.

Unless/until we require that the entire page must be rendered in a  
single action, this will remain necessary.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]