[dev] [commits] Horde branch master updated. 9feb624e174f5f571f3756d0ce89c8cd1124d4b0

[Michael J Rubinsky]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Michael J Rubinsky <mrubinsk at horde.org>:
>
>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>
>>> Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:
>>>
>>>> commit 8bc8f6433f808c5761bee3d609d230daf4281f23
>>>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>>>> Date:   Fri Feb 14 14:19:54 2014 -0500
>>>>
>>>>  Compress UID lists before serialization, if large enough.
>>>>
>>>> framework/ActiveSync/lib/Horde/ActiveSync/Folder/Imap.php |   97  
>>>> ++++++++++++-
>>>> 1 files changed, 96 insertions(+), 1 deletions(-)
>>>>
>>>> http://github.com/horde/horde/commit/8bc8f6433f808c5761bee3d609d230daf4281f23
>>>> http://git.horde.org/horde-git/-/commit/8bc8f6433f808c5761bee3d609d230daf4281f23
>>>
>>> Any reason you aren't using Horde_Imap_Client_Ids?  Doesn't seem  
>>> to be any reason to have to duplicate the code.
>>
>> Because there is no guarantee that some (non-horde) client code is  
>> using Horde_Imap_Client to connect to the IMAP server.
>
> It's already an optional requirement ... and I would assume that  
> most people WOULD use it since the Adapter is already written ... so  
> if it was me I would think the argument of reusing existing code vs.  
> the additional effort it takes to install that existing code are  
> heavily weighted towards the former.

All the code that uses  
Horde_Imap_Client::/Horde_ActiveSync_Imap_Adapter:: is contained in  
Horde_Core_ActiveSync_Driver::. Explicitly creating a new instance of  
Horde_Imap_Client_Ids:: inside of the folder object would defeat the  
purpose of keeping that code uncoupled.

I agree that any non-horde code could (and probably should) use  
Horde_Imap_Client:: - that's why I placed the adapter class in  
Horde_ActiveSync instead of Horde_Core, but I'd rather not force it  
for need of a single method.

> Agreed it's ultimately your choice.  Although I would explicitly  
> indicate the LGPLv2.1 -> GPL license conversion you used for  
> licensing purposes to make clear this code in ActiveSync is no  
> longer covered by LGPL v2.1 (i.e. the Section 3 election provision  
> of LGPL).

I'll add text to those methods' headers to make it clearer, thanks.


-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5849 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/dev/attachments/20140217/cb31a8bb/attachment.bin>