[dev] [commits] Horde branch master updated. 86ef55186f749ab0a37e0d6389ddb75e13e9a66e

[Michael J Rubinsky]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Michael J Rubinsky <mrubinsk at horde.org>:
>
>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>
>>> commit d2cd083472aae600ab4382ac35cc701314b63933
>>> Author: Michael M Slusarz <slusarz at horde.org>
>>> Date:   Tue Mar 18 13:35:09 2014 -0600
>>>
>>>   Revert "Use the default SMTP port of 25, not the MSA port of 587."
>>>
>>>   This reverts commit 3f373410d7d68db94f209efb09c67e343764516f.
>>>
>>>   Conflicts:
>>>   	framework/Smtp/lib/Horde/Smtp.php
>>>
>>>   This was incorrect.  Horde_Smtp, as of 1.0.0, used 587 by default.  If
>>>   Horde the application defaulted to port 25, that needs to be addressed
>>>   at the Horde-level instantiation, not in this package.
>>>
>>> framework/Smtp/lib/Horde/Smtp.php |    4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> http://github.com/horde/horde/commit/d2cd083472aae600ab4382ac35cc701314b63933
>>> http://git.horde.org/horde-git/-/commit/d2cd083472aae600ab4382ac35cc701314b63933
>>
>> This a BC break.
>
> Your logic is revesed - it fixes a BC break.
>
> Horde_Smtp 1.0.0 shipped with the port as 587.  Changing that value  
> in a version > 1.0.0 breaks BC with Horde_Smtp version 1.0.0.

I would argue that the initial Horde_Smtp 1.0.0 release as written,  
was a BC break with the current behavior/configuration of Horde.

>> If Horde_Smtp is upgraded, but Horde is not, the user will  
>> potentially be unable to send email.
>
> If you are talking about the fact that H5 has a configuration file  
> that defaults to sending SMTP on port 25, that has nothing to do  
> with backward compatibility in the Horde_Smtp package.

Yes, it does, because unless the Horde configuration is  
reviewed/changed sending email would be broken with the default that  
is advertised in the configuration page. I am unable to find anything  
in any UPGRADING file to indicate this. It is irrelevant if it was  
*supposed* to say something else or the RFC says is should be  
something else.

> When we switched to using Horde_Smtp sometime during H5, and didn't  
> correctly set the port when instantiating Horde_Smtp, that was an  
> implementation bug in **horde**, not a logic/configuration bug in  
> Horde_Smtp.  Thus, it needed to be fixed in horde, not Horde_Smtp  
> (which was done).
>
> I can simply flip your logic and say "What if Horde is upgraded and  
> Horde_Smtp is not?" and, without fixes in Horde_Core, this issue  
> would never be fixed.

No, because we can enforce the dependency via PEAR when upgrading  
Horde[/Core]. We can't enforce the dependency in the other direction.
-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5849 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/dev/attachments/20140323/4b63ba0d/attachment.bin>