[dev] Horde_Imap_Client test failure with latest PHP

[Remi Collet]

After lot of discussion with other PHP developers:

- code in previous PHP is not consistent.

Other class constructors from ext/date extension return NULL on failure.

- this could raise segfault on some situation (bug #67118)

return NULL is the correct solution, fix #67118, but breaks some code,
including Horde.


So temporary fix have been applied in 5.4.30, 5.5.14 and 5.6.0:

http://git.php.net/?p=php-src.git;a=commit;h=1fe9f1e4f572d7b4d5a3872f41ea61e71fb563bf

Test inspired from Horde_Imap_Client_DateTime added:

http://git.php.net/?p=php-src.git;a=commit;h=15d8c80ead75be976c18a66b0933cf52f3e6579f


But the correct behavior have be restored in master.

http://git.php.net/?p=php-src.git;a=commit;h=f11f7f56013c5ee4e6009997602e9b5a64064909

http://git.php.net/?p=php-src.git;a=commit;h=f1ef7018f036de3b0d149ea0bc4575767b9bb413


So current horde code will continue to work for some time,
giving you time for a better solution.

Summary : parent::__construct could be called only once.


/me trying to make PHP better and everyone happy (not easy)


Regards,
Remi.