[dev] [commits] Horde branch master updated. f3f63ebd0015bc67ea9ba715f737f6355520b909

Ralf Lang lang at b1-systems.de
Wed Nov 19 07:16:45 UTC 2014


On 18.11.2014 20:57, Michael M Slusarz wrote:
> Quoting Jan Schneider <jan at horde.org>:
> 
>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>
>>> Quoting Jan Schneider <jan at horde.org>:
>>>
>>>> commit 2691fc5244ed2eec6578288b7f3183c93ccb2c70
>>>> Author: Jan Schneider <jan at horde.org>
>>>> Date:   Tue Nov 18 15:09:18 2014 +0100
>>>>
>>>>   Indention
>>>>
>>>> framework/Mime/lib/Horde/Mime/Headers.php |    2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> http://github.com/horde/horde/commit/2691fc5244ed2eec6578288b7f3183c93ccb2c70
>>>>
>>>
>>> No, this is actually correct.
>>>
>>> I recently learned this is the "correct" formatting for all
>>> subsequent lines in a class declaration, at least given our current
>>> standards.  (Of course, I can't exactly recall where I saw this.) 
>>> And I agree - we indent everything else (other than switch case
>>> statements) that is a continuation.
>>
>> This is nowhere mentioned in our written down standards AFAICS, but we
>> have a defacto standard in existing code that lines everything up.
>> PSR-2, which we should follow in Horde 6, since it's already almost
>> identical to the Horde CS (and of course originates in Horde CS), has
>> a slightly different approach. It only allows wrapping of interfaces,
>> and then ... well see yourself in section 4.1:
>> http://www.php-fig.org/psr/psr-2/
> 
> 1. OK
> 2. Why are we not a member project of PHP-fig?

I was under the impression you were, through Gunnar?


-- 
Ralf Lang
Linux Consultant / Developer
Tel.: +49-170-6381563
Mail: lang at b1-systems.de
B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.horde.org/archives/dev/attachments/20141119/3bd063da/attachment.bin>


More information about the dev mailing list