[dev] [commits] Horde branch master updated. 9ac03eb9986f297753bbd15fd4191f0fa3f44c5b

[Michael M Slusarz]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Michael J Rubinsky <mrubinsk at horde.org>:
>
>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>
>>
>>> commit dfd1041a4c146d8754686cd9530e9fe2a44054aa
>>> Author: Michael M Slusarz <slusarz at horde.org>
>>> Date:   Thu Jan 22 02:45:18 2015 -0700
>>>
>>>   Fix tests
>>>
>>>   Can't use serialized objects, since there is no guarantee (like here)
>>>   that the internals won't change.
>>>
>>> framework/ActiveSync/test/Horde/ActiveSync/ImapAdapterTest.php     
>>> |    7 ++--
>>> .../ActiveSync/test/Horde/ActiveSync/MessageBodyDataTest.php       
>>> |    8 ++++-
>>> 2 files changed, 11 insertions(+), 4 deletions(-)
>>>
>>> http://github.com/horde/horde/commit/dfd1041a4c146d8754686cd9530e9fe2a44054aa
>>
>>
>> These are Horde_Imap_Client_Fetch_Results objects. Since these  
>> objects contain internal Horde_Mime_Part and Horde_Mime_Header  
>> objects, perhaps these objects (or Horde_Imap_Client_Data_Fetch  
>> objects) should be marked not serialize-able.
>
> That class is serializable.  (Thought I had unit tests for this but  
> I didn't.  Just created and this claim has been verified).

Spoke too soon.

Data_Fetch objects won't be correctly unserialized if they contain  
stream data, since this data is not converted to a string  
representation on serialize() - this data is lost.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]