[horde] css2horde.php bug

Ian.H ian at digiserv.net
Fri Mar 14 09:37:29 PST 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Evening all,

I don't know how much this is used by people, and tbh, I've only just
tried it out of curiousity, but I've spotted a bug within the code.

I often use single quotes in CSS files for background images for
example:


body {
  background-image:url('/gfx/someimage.jpg');
}


When run through the css2horde util script, that produces:


$css['body ']['background-image'] = 'url('/gfx/background.gif')';


This as far as I can tell, would error on bad string concatenation.

I've ammended css2horde.php to resolve the issue by forcing the use
of "
rather than '.

I've created a .diff file to enable easy patching if anyone is
interested in this (attached to mail).



Regards,

  Ian

- -- 
digiServ Network
Development Team.

-----BEGIN PGP SIGNATURE-----
Version: PGP 8.0

iQA/AwUBPnIS/Wfqtj251CDhEQJgoACfRgaySPGNXjSQgeoUJ7Xr09vIkzMAoKdL
yDVlJ02rYbclNBzLaKGKrGZr
=cCSp
-----END PGP SIGNATURE-----



------------------------------------------------------------
              digiServ Network - Web solutions

www.digiserv.net                        hosting.digiserv.net
irc.digiserv.net                          forum.digiserv.net

        Scripting, Web design, development & hosting
------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: css2horde.diff
Type: application/octet-stream
Size: 235 bytes
Desc: not available
Url : http://lists.horde.org/archives/horde/attachments/20030314/c59a8208/css2horde-0002.obj


More information about the horde mailing list