[horde] Bug found and fixed

Johan Fredriksson eskil at e.kth.se
Fri Jan 21 03:18:46 PST 2005


Hello!

I have not read (on this list) about anyone else having this problem.
I think that is quite strange since it have troubled me for quite some
time with both Horde-3.0-ALPHA with IMP-4.0-ALPHA and Horde-3.0.2 with
IMP-4.0.1.

The problem is that IMP sonetimes "forget" which mailbox I'm currently
reading. Clicking on a mail results ether in the error message "This
message could not be found", or a message with the same index from another
mailbox. Reloading the frame brings me back to the mailbox i was reading
previously.

After endles hours of debuging-by-echo I narrowed down the problem enough
to produce a patch that solves (or works around) this bug. Here it is:


--- imp/lib/Mailbox.php.orig 18 Jan 2005 17:05:13 -0000      1.2
+++ imp/lib/Mailbox.php 20 Jan 2005 11:41:48 -0000      1.3
@@ -171,5 +171,6 @@
     function setNewIndex($index)
     {
         $this->_setIndex($index);
+       $this->_getSortedIndex();
         $this->_setSorted();
         $this->_setArrayIndex();
--- imp/lib/Search.php  3 Jan 2005 13:55:56 -0000       1.1
+++ imp/lib/Search.php  14 Jan 2005 15:05:01 -0000      1.2
@@ -177,5 +177,7 @@
             $params['thismailbox'] = $mailbox;
             $params['mailbox'] = $imp['mailbox'];
-        }
+        } else {
+           $params['mailbox'] = $mailbox;
+       }

         return $params;



More information about the horde mailing list