[horde] Problem with HTML compose [SOLVED]

Michael M Slusarz slusarz at horde.org
Tue Jul 16 22:06:39 UTC 2013


Quoting sbasurto at soft-gator.com:

> In the function:
>
>  protected function _addExternalData($html)
>     {
>         /* Return immediately if related conversion is turned off via
>          * configuration. */
>         if (empty($GLOBALS['conf']['compose']['convert_to_related'])) {
>             return;
>         }
> // more code here.
>
> In my case I have the $GLOBALS['conf']['compose']['convert_to_related']
> turned off. So returns with nothing, and in the call the variable
> $body_html is equaled to what the function returns, so after the call it
> contains nothing.

This was fixed looooong ago:

-----

commit 9f267487cd95c3fae9d9f12b0bb5bff71bab38cd
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date:   Thu Dec 13 19:26:24 2012 +0100

     Fix loss of HTML body if related conversion is turned off

     Signed-off-by: Michael M Slusarz <slusarz at horde.org>

diff --git a/imp/lib/Compose.php b/imp/lib/Compose.php
index 060ed25..853451a 100644
--- a/imp/lib/Compose.php
+++ b/imp/lib/Compose.php
@@ -2556,7 +2556,7 @@ class IMP_Compose implements ArrayAccess,  
Countable, Iterator, Serializable
          /* Return immediately if related conversion is turned off via
           * configuration. */
          if (empty($GLOBALS['conf']['compose']['convert_to_related'])) {
-            return;
+            return $html;
          }

          $client = $GLOBALS['injector']

-----

michael

___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the horde mailing list