[horde] Git Errors since last pull

[Simon B]

On Mon, 7 Nov 2022 at 10:30, Simon B <simon.buongiorno at gmail.com> wrote:
>
> Hi,
>
> I do a regular pull of Git on Mondays.  Since today's update, I am getting these errors in the logs...
>
> [Mon Nov 07 09:14:17.660451 2022] [:error] [pid 29983] [client 217.110.192.38:60062] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:18:42.345592 2022] [:error] [pid 30168] [client 217.110.192.38:52688] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:19:15.478257 2022] [:error] [pid 29979] [client 217.110.192.38:8685] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:22:26.859395 2022] [:error] [pid 29380] [client 2a00:20:59:db40:59a8:50ce:920b:38bd:60850] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:22:27.146689 2022] [:error] [pid 29982] [client 2a00:20:59:db40:59a8:50ce:920b:38bd:60851] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:23:20.170378 2022] [:error] [pid 16360] [client 217.110.192.38:5194] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:26:12.667671 2022] [:error] [pid 16363] [client 217.110.192.38:53794] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:26:22.675380 2022] [:error] [pid 16372] [client 217.110.192.38:42380] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:26:22.680569 2022] [:error] [pid 16371] [client 217.110.192.38:15488] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:26:23.162526 2022] [:error] [pid 16360] [client 217.110.192.38:18120] PHP Parse error:  syntax error, unexpected ':', expecting ';' or '{' in /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
>
> How can I roll back?

For anyone else with this issue - the solution is:

 ./horde-git-tools/bin/horde-git-tools git run "reset --hard
master@{1.days.ago}"

Unfortunately, this also reverted some security fixes,

In essence - and this is not a complaint - the "problem" was with the
commited updates to better support PHP7+
(https://github.com/horde/turba/pull/11/commits/40978808ac0b539a523f5696be315d0e255d9adb)
  I am still running 5.6 because support until now was flakey.

Most of the errors were fixable, but one resultes in IMP is marked as
authenticated, but no credentials can be found in the session. in
/Core/lib/Horde/Registry.php:1679 - and that one I could not fix,
hence the rollback.

Regards

Simon