[horde] Finished importing horde FW_6 to packagist.org / composer / compatibility with newer PHP versions

Wed Jan 3 17:15:04 UTC 2024

Hello Brent,

I have a lowercase s in my installation.
My composer.json looks nearly the same (I have no repository section). 
Could you please check in the composer.lock file which version of 
horde/core you are using. Looks like this:
         {
             "name": "horde/core",
             "version": "v3.0.0alpha15",
             "source": {
                 "type": "git",
                 "url": "https://github.com/horde/Core.git",
                 "reference": "cbb72f6d65c9eedaaecdbc102190785a1b281419"
             },
             "dist": {
                 "type": "zip",
                 "url": 
"https://api.github.com/repos/horde/Core/zipball/cbb72f6d65c9eedaaecdbc102190785a1b281419",
                 "reference": "cbb72f6d65c9eedaaecdbc102190785a1b281419",
                 "shasum": ""
             },
             "require": {
Maybe a "composer require horde/core:dev-FRAMEWORK_6_0" helps here?

BR
Michael

Am 28.12.23 um 18:04 schrieb Brent:
>  Maybe I'm doing it wrong, in that case? The "fix" is correct 
> (lowercase "s" fixes the issue), but I appear to be pulling something 
> else.
>
> My install went like:
>
> Create composer.json file in a directory, then run:
> $ composer update
> <a bunch of stuff gets installed>
>
> Then I see that the file has the capital S instead of the lowercase s 
> in vendor/horde/core/lib/Horde/Core/Ui/VarRenderer/Html.php
>
>
> Here's my composer.json (which I guess is wrong?):
>
> -------------
> {
>     "name": "horde/bundle",
>     "description": "A base project for a horde installation",
>     "type": "project",
>     "repositories": {
>         "0": {
>             "url": "https://packagist.org/",
>             "type": "composer"
>         }
>     },
>     "require": {
>         "composer-plugin-api": "^2.0",
>         "horde/horde-installer-plugin": "^2.5.1 || dev-FRAMEWORK_6_0 
> || dev-master",
>         "horde/horde": "^6 || dev-FRAMEWORK_6_0",
>         "horde/routes": "^3 || dev-FRAMEWORK_6_0",
>         "horde/hordectl": "^1 || dev-FRAMEWORK_6_0 || dev-master",
>         "pear/console_color2": "^0.1.2",
>         "pear/console_table": "^1.3",
>         "horde/imp": "dev-FRAMEWORK_6_0",
>         "horde/cache": "dev-FRAMEWORK_6_0",
>         "horde/turba": "dev-FRAMEWORK_6_0",
>         "horde/ingo": "dev-FRAMEWORK_6_0",
>         "horde/kronolith": "dev-FRAMEWORK_6_0",
>         "horde/mapi": "dev-FRAMEWORK_6_0",
>         "horde/nag": "dev-FRAMEWORK_6_0",
>         "horde/mnemo": "dev-FRAMEWORK_6_0",
>         "horde/gollem": "dev-FRAMEWORK_6_0",
>         "horde/activesync": "dev-FRAMEWORK_6_0"
>     },
>     "require-dev": {
>         "horde/test": "^3 || dev-FRAMEWORK_6_0 || dev-master"
>     },
>     "license": "GPL-3.0-only",
>     "authors": [
>         {
>             "name": "Ralf Lang",
>             "email": "lang at b1-systems.de"
>         }
>     ],
>     "minimum-stability": "dev",
>     "prefer-stable": true,
>     "extra": {
>         "installer-types": [
>             "horde-library",
>             "horde-application"
>         ]
>     },
>     "config": {
>         "allow-plugins": {
>             "horde/horde-installer-plugin": true
>         }
>     }
> }
> ------------
>
> Quoting Lang, Ralf <ralf.lang at gmail.com>:
>
>> Hello Brent,
>>
>>
>>   Am 27/12/2023 um 22:44 schrieb Brent:
>>
>>> Ok, thanks...that fixed it. I note that a few fixes that were 
>>> discussed in this list aren't in included. You say you want a "PR", 
>>> but what is that? Is there a mechanism for reporting issues? No 
>>> problem to do that, I just don't know what a PR is, offhand.
>>
>>   I am fine with any kind of report. ML is OK, Wiki page is OK for 
>> now, Horde Ticket System is most preferred.
>>
>>   MAILSCANNER HAS DETECTED A POSSIBLE FRAUD ATTEMPT FROM 
>> "BUGS.HORDE.ORG" CLAIMING TO BE MAILSCANNER HAS DETECTED A POSSIBLE 
>> FRAUD ATTEMPT FROM "BUGS.HORDE.ORG" CLAIMING TO BE Tickets :: New 
>> Ticket (horde.org)[1]
>>
>>   A Pull Request is a type of submitting a patch through Github 
>> together with a means to discuss and change the patch.
>> Those who send pull requests don't need to open a ticket or another 
>> means of communication, everything will happen right there.
>>
>>> To wit, there's a type-o in the turba package. If you have an image 
>>> for a contact, it'll trip up on it. There's a capital "S" instead of 
>>> a lowercase one: <install 
>>> dir>/vendor/horde/core/lib/Horde/Core/Ui/VarRenderer/Html.php Line 
>>> 209....replace with the capital "S" after the id= Broken:  $html .= 
>>> sprintf('<input class="button" name="%s" id="%S" type="submit" 
>>> value="%s" /> ',  Fixed:  $html .= sprintf('<input class="button" 
>>> name="%s" id="%s" type="submit" value="%s" /> ',   brent
>>
>>   That one confuses me. You say it's still broken and that your 
>> preferred / fixed version has lowercase s
>>
>>   MAILSCANNER HAS DETECTED A POSSIBLE FRAUD ATTEMPT FROM "GITHUB.COM" 
>> CLAIMING TO BE MAILSCANNER HAS DETECTED A POSSIBLE FRAUD ATTEMPT FROM 
>> "GITHUB.COM" CLAIMING TO BE 
>> Core/lib/Horde/Core/Ui/VarRenderer/Html.php at FRAMEWORK_6_0 · 
>> horde/Core (github.com)[2]
>>
>>   We committed that change in October 25.
>>
>>   MAILSCANNER HAS DETECTED A POSSIBLE FRAUD ATTEMPT FROM "GITHUB.COM" 
>> CLAIMING TO BE MAILSCANNER HAS DETECTED A POSSIBLE FRAUD ATTEMPT FROM 
>> "GITHUB.COM" CLAIMING TO BE Update Html.php · horde/Core at 7e1e507 
>> (github.com)[3]
>>
>>   v3.0.0alpha15 has this patch, too.
>>
>>   Can you describe how you end up with the broken version when 
>> installing / upgrading?
>>
>>   Regards
>>
>>
>> Ralf
>>
>>> -----Original Message-----
>>>> From: "Lang, Ralf" <ralf.lang at gmail.com>[4]Date: Wed, 27 Dec 2023 
>>>> 08:12:42 +0100 To: horde at lists.horde.org, 
>>>> impuser at bitrealm.comSubject: Re: [horde] Finished importing horde 
>>>> FW_6 to packagist.org /  composer / compatibility with newer PHP 
>>>> versions X-Spam-Status: No, No  Hi Brent,  thank you for 
>>>> reporting.  I have fixed this now and added an install test for 
>>>> ingo's set of packages.  Workflow runs · horde/bundle (github.com) 
>>>> <https://github.com/horde/bundle/actions>[5] This will probably 
>>>> improve as I go along   Am 26/12/2023 um 19:44 schrieb Brent:
>>>>>  I note a missing "horde/managesieve" component, required for ingo 
>>>>> (rules) now?  Happy Holidays!  brent  Quoting ralf.lang at ralf-lang.de:
>>>>>> Hi Michael,  I will do that and apply any missing / reported 
>>>>>> fixes. But no timeline - I am with the family these days.Wish you 
>>>>>> all a merry christmas and a happy new year.  Am 23. Dezember 2023 
>>>>>> 12:26:25 MEZ schrieb Michael Schlueter <michael at johalla.de>[6]:
>>>>>>> Hello Ralf,  What a great early Christmas gift. It works great 
>>>>>>> for me :-)  Would it be possible to create the horde/mapi 
>>>>>>> package so I can install activesync?  I had an issue with turba 
>>>>>>> (Non-static method Horde_Form::getType() cannot be called 
>>>>>>> statically) but a fix is already documented under: 
>>>>>>> https://wiki.horde.org/Doc/Dev/H6/Developer/KnownIssues Also I 
>>>>>>> can see the rampage warnung you can find on the KnowIssues page. 
>>>>>>> This time I changed it to require_once dirname(__FILE__, 4) . 
>>>>>>> '/vendor/autoload.php'; Which seems to solve it. Thanks a lot 
>>>>>>> and have a merry Christmas.  Cheers Michael  Zitat von Lang, 
>>>>>>> Ralf <ralf.lang at gmail.com>[4]:
>>>>>>>> Hello,  Finally, all horde applications and libraries have been 
>>>>>>>> imported to the global composer repository, packagist.org  You 
>>>>>>>> can find the index here Packagist 
>>>>>>>> <https://packagist.org/packages/horde/>[7] Original code from 
>>>>>>>> the maintaina-com fork has been rebased on the current master 
>>>>>>>> branch. I imported the original tags from maintaina. These are 
>>>>>>>> alpha versions. I did not do anything about pear. The only 
>>>>>>>> changes to master affect the composer.json file. I made it 
>>>>>>>> compatible with current versions of composer and packagist but 
>>>>>>>> I doubt anybody really used them in their previous state.  The 
>>>>>>>> "master" branch is generally left alone for those who need to 
>>>>>>>> run horde in its previous state based on PHP 7.2 - New 
>>>>>>>> development targets the FRAMEWORK_6_0 branch Maintaina's 
>>>>>>>> FRAMEWORK_6_0 branch originally targeted PHP 7.4, 8.0 and 8.1 
>>>>>>>> and is known to work on these versions within reasonable limits 
>>>>>>>> of testing. Active upstream support for PHP 8.1 has ended some 
>>>>>>>> weeks ago. Security fixes are available for the next 11 months. 
>>>>>>>> I am currently working on full support for PHP 8.2 and 8.3.  I 
>>>>>>>> just finished the importing work. While the unit tests for 
>>>>>>>> almost all code has been ported to PHPUnit 9 and SHOULD work on 
>>>>>>>> the latest PHP, the CI pipelines are currently broken. This is 
>>>>>>>> a high priority currently.  If you find any patch from master 
>>>>>>>> branch missing in FRAMEWORK_6_0, please create a PR or simply 
>>>>>>>> comment if you cannot create the patch yourself.  Regards  Ralf 
>>>>>>>> --  Horde mailing list Frequently Asked Questions: 
>>>>>>>> http://horde.org/faq/To unsubscribe, mail: 
>>>>>>>> horde-unsubscribe at lists.horde.org
>>>>>>>
>>>>>>> --  Horde mailing list Frequently Asked Questions: 
>>>>>>> http://horde.org/faq/To unsubscribe, mail: 
>>>>>>> horde-unsubscribe at lists.horde.org
>>>>>>
>>>>>> --  Horde mailing list Frequently Asked Questions: 
>>>>>> http://horde.org/faq/To unsubscribe, mail: 
>>>>>> horde-unsubscribe at lists.horde.org
>
>
>
> Links:
> ------
> [1] https://bugs.horde.org/ticket/create.php
> [2] 
> https://github.com/horde/Core/blob/FRAMEWORK_6_0/lib/Horde/Core/Ui/VarRenderer/Html.php#L209
> [3] 
> https://github.com/horde/Core/commit/7e1e507b7d01e36f2e96a93d222fed9a5fb16ca1
> [4] mailto:ralf.lang at gmail.com
> [5] https://github.com/horde/bundle/actions
> [6] mailto:michael at johalla.de
> [7] https://packagist.org/packages/horde/