[imp] Sort bug (again)

[Eugene Miretsky]

Chuck Hagenbuch wrote:
> 
> Quoting Eugene Miretsky <eugene@invision.net>:
> 
> > The simplest way to eliminate this warning is to change line 373 in
> > mailbox.php3
> >   from: $msgnum = $sorted[$i-1];
> >   to  : $msgnum = @$sorted[$i-1];
> >
> > I was wandering if this fix can be applied to imp distribution.
> 
> Instead of silencing errors that might be valid for everyone, why don't you just
> change $default->error_reporting (in imp/config/defaults.php3) to a less picky
> level?
> 

I don't think it has anything to do with IMP error_reporting -- it's PHP
error when you try to access out of bounds element.  I can silince PHP, 
but this is as bad as silincing IMP.  Also, since @... approach is
used quite heavily in IMP, I don't think this would create such a problem --
after  all messages are still displayed properly.


-- 
  Eugene Miretskiy <eugene@invision.net>
  InVision.com, INC.  (631) 543-1000
  www.invision.net  /  www.longisland.com


>From chuck@horde.org Date: Fri,  1 Dec 2000 10:01:06 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact imp-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list imp@lists.horde.org
Received: (qmail 1378 invoked from network); 1 Dec 2000 15:01:50 -0000
Received: from r94aag005136.sbo-smr.ma.cable.rcn.com (HELO marina.horde.org) (146.115.120.202)
  by horde.org with SMTP; 1 Dec 2000 15:01:50 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 56FC83CB3; Fri,  1 Dec 2000 10:01:06 -0500 (EST)
Received: from 206.243.191.252 ( [206.243.191.252])
	as user chuck@marina by marina.horde.org with HTTP;
	Fri,  1 Dec 2000 10:01:06 -0500
Message-ID: <975682866.3a27bd32313e1@marina.horde.org>
Date: Fri,  1 Dec 2000 10:01:06 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: imp@lists.horde.org
References: <3A253A5E.A6F0A5D2@invision.net> <975639401.3a27136995c2c@nirgal.your.mom> <3A27B925.D96D5AC9@invision.net>
In-Reply-To: <3A27B925.D96D5AC9@invision.net>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.6-cvs
Subject: Re: [imp] Sort bug (again)

Quoting Eugene Miretsky <eugene@invision.net>:

> I don't think it has anything to do with IMP error_reporting -- it's PHP
> error when you try to access out of bounds element.  I can silince PHP, 
> but this is as bad as silincing IMP.  Also, since @... approach is
> used quite heavily in IMP, I don't think this would create such a problem --
> after  all messages are still displayed properly.

$default->error_reporting is what IMP uses to set php's error reporting level 
too. And instead of _always_ silencing this particular error, you can just 
change your config file and have it be more quiet locally.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"If you can't stand the heat, get out of the chicken!" - Baby Blues