[imp] Compose "save a copy in" checkbox broke?

Jon Parise jon@horde.org
Fri, 4 Jan 2002 00:04:16 -0500


---------------------- multipart/mixed attachment
On Thu, Jan 03, 2002 at 05:32:51PM -0600, Barry Pederson wrote:

> In IMP 3.0 final, when composing a message, unchecking the "Save a copy
> in" checkbox doesn't seem to prevent a copy from being saved in the
> selected folder.
 
Good find.  That's definitely a bug.  I just committed a fix to
the HEAD branch.  I'm attaching a patch here which will work
against IMP 3.0.  I'll commit it to the stable branch tomorrow so
that it will show up in IMP 3.1 if there are no problems.

-- 
Jon Parise (jon@csh.rit.edu)  .  Information Technology (2001)
http://www.csh.rit.edu/~jon/  :  Computer Science House Member

---------------------- multipart/mixed attachment
Index: compose.php
===================================================================
RCS file: /repository/imp/compose.php,v
retrieving revision 2.369.2.11
diff -u -r2.369.2.11 compose.php
--- compose.php	2 Jan 2002 17:05:23 -0000	2.369.2.11
+++ compose.php	4 Jan 2002 03:48:00 -0000
@@ -750,8 +750,11 @@
              $entry = sprintf("%s Message sent to %s from %s",
                               $HTTP_SERVER_VARS['REMOTE_ADDR'], $recipients, $imp['user']);
              Horde::logMessage($entry, __FILE__, __LINE__, LOG_INFO);
-             
-             if ($identity->saveSentmail()) {
+
+             /* Should we save this message in the sent mail folder? */
+             $save_sent_mail = (Horde::getFormData('save_sent_mail') == 'on');
+
+             if ($save_sent_mail && $identity->saveSentmail()) {
                  /* Keep Bcc: headers on saved messages. */
                  if (!empty($f_bcc)) $headers['Bcc'] = $f_bcc;
                  

---------------------- multipart/mixed attachment--


>From imp@gurubase.com Date: Fri,  4 Jan 2002 14:00:48 +0800
Return-Path: <imp@gurubase.com>
Mailing-List: contact imp-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list imp@lists.horde.org
Received: (qmail 78800 invoked from network); 4 Jan 2002 05:57:20 -0000
Received: from unknown (HELO master.gurubase.com) (@202.140.67.155)
  by clark.horde.org with SMTP; 4 Jan 2002 05:57:20 -0000
Received: by master.gurubase.com (Postfix, from userid 99)
	id B741F1F242; Fri,  4 Jan 2002 14:00:49 +0800 (HKT)
Received: from 192.168.1.245 ( [192.168.1.245])
	as user imp@localhost by mail-dev.gurubase.com with HTTP;
	Fri,  4 Jan 2002 14:00:48 +0800
Message-ID: <1010124048.3c3545103e529@mail-dev.gurubase.com>
Date: Fri,  4 Jan 2002 14:00:48 +0800
From: imp@gurubase.com
To: imp@lists.horde.org, Jan Schneider <jan@horde.org>
References: <1010037279.3c33f21f8da12@mail-dev.gurubase.com> <1010061217.3c344fa1223de@linux.wg.de>
In-Reply-To: <1010061217.3c344fa1223de@linux.wg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=Big5
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 3.0
X-Originating-IP: 192.168.1.245
Subject: Re: [imp] Problem of user interface of Chinese version

Thanks... Then which file(s) I should change in order for the menu text to appear 
correctly? 

Thanks and regards,
Boris


¤Þ¥Î Jan Schneider <jan@horde.org>:

> Zitat von imp@gurubase.com:
> 
> > Dear all, 
> > 
> > I found 2 problems in my Chinese (Traditional) version of IMP version 3.0
> > RC3, with 
> > Turba 1.0 version RC3. 
> > 
> > 1. The tag of Addressbook in menu bar is in English while other menu
> > items are in 
> > Chinese 
> > 
> > 2. The "From", "To" tag in messages  ( Chinese ) are wrapped into 2 or 3
> > lines. 
> 
> These are not the only strings not translated, and Chinese is not the only 
> that misses some translations. All the translations are contributed thanks 
> to the nice work of some users out there, so that we can't assure that they
> 
> are alway up to date.
>  
> > I've attached an image of my screen. 
> 
> Attachments other than text/plain are stripped by the mailing list
> software.
> 
> Jan.
> 
> ::::::::::::::::::::::::::::::::::::::::
> AMMMa AG - discover your knowledge
> :::::::::::::::::::::::::::
> Detmolder Str. 25-33 :: D-33604 Bielefeld
> fon +49.521.96878-0 :: fax  +49.521.96878-20
> http://www.ammma.de
> ::::::::::::::::::::::::::::::::::::::::::::::
> 
> -- 
> IMP mailing list: http://horde.org/imp/
> Archive: http://marc.theaimsgroup.com/?l=imp&r=1&w=2
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: imp-unsubscribe@lists.horde.org
> 
> 
> 




-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/


>From chichken@interbase.hu Date: 04 Jan 2002 10:20:09 +0100
Return-Path: <chichken@interbase.hu>
Mailing-List: contact imp-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list imp@lists.horde.org
Received: (qmail 83779 invoked from network); 4 Jan 2002 09:18:15 -0000
Received: from south.interbase.hu (HELO interbase.hu) (217.65.100.7)
  by clark.horde.org with SMTP; 4 Jan 2002 09:18:15 -0000
Received: (from root@localhost)
	by interbase.hu (8.11.6/8.11.6) id g049IGF17229
	for imp@lists.horde.org; Fri, 4 Jan 2002 10:18:16 +0100
Received: from fried.ibase (ip98-137.ktv.tiszanet.hu [217.65.98.137])
	by south.interbase.hu (8.11.6/8.11.6) with ESMTP id g049IFS17221
	for <imp@lists.horde.org>; Fri, 4 Jan 2002 10:18:15 +0100
From: Nagy =?ISO-8859-1?Q?P=E9ter?= <chichken@interbase.hu>
To: implista <imp@lists.horde.org>
Content-Type: text/plain; charset=ISO-8859-2
X-Mailer: Evolution/1.0 (Preview Release)
Date: 04 Jan 2002 10:20:09 +0100
Message-Id: <1010136009.11426.4.camel@fried>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by south.interbase.hu id g049IFS17221
Subject: incorrect date

Hi all

I found an incorrect date in the main site.

This field always show this: 12/31/01

In the mail header the date is correct.

Idea?


-- 

 Nagy Péter 
____________________
Interbase Bt.
PGP key ID: B4000D38