[imp] sql.php patches for Oracle.

[Mike Coughlan]

OK, Thanks Liam for this post
http://marc.theaimsgroup.com/?l=imp&m=100069811326015&w=2

After some flailing on the list, I finally get what you are saying.

For those relying on Oracle, here is the necessary patch:

/horde/lib/Prefs/sql.php
line 184
--               $name = trim($row['pref_name']);
++               $name = trim($row['PREF_NAME']);

line 186
--                    $this->prefs[$name]['val'] = $row['pref_value'];
++                    $this->prefs[$name]['val'] = $row['PREF_VALUE'];

If some clever PHP person can find an appropriate placement for a
Lowercase() function, I would appreciate it.  As you might guess, my PHP
skills are nonexistent.

Would the Horde dev team consider this to be a bug in the OCI8 driver?

Thanks all.








> -----Original Message-----
> From: Mike Coughlan [mailto:mcoughlan@gothambroadband.com]
> Sent: Tuesday, January 15, 2002 9:58 AM
> To: imp@lists.horde.org
> Subject: [imp] sql.php patches for Oracle.
>
>
> I saw this posting regarding IMP and the fact that one must change all of
> the table and field references in horde/lib/Prefs/sql.php to
> upper case for
> Oracle.
>
> I did this as shown below, but it did not work.
>
> /* Build the SQL query. */
>         $query = 'SELECT PREF_SCOPE, PREF_NAME, PREF_VALUE FROM ';
>         $query .= $this->params['table'] . ' ';
>         $query .= 'WHERE PREF_UID = ' . $this->db->quote($this->user);
>         $query .= ' AND (PREF_SCOPE = ' . $this->db->quote($this->scope);
>         $query .= " OR PREF_SCOPE = 'horde') order by pref_scope";
>
> Can someone please tell me if I need to run some Upper() function on
> $this->params['table'] as well?  I do not know PHP and am unsure of the
> complete patch.
>
> Thanks for any assistance.
>
> http://marc.theaimsgroup.com/?l=imp&m=100069811326015&w=2
>
>
> --
> IMP mailing list: http://horde.org/imp/
> Archive: http://marc.theaimsgroup.com/?l=imp&r=1&w=2
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: imp-unsubscribe@lists.horde.org
>
>