[imp] Re: [dev] custom trailer patch

[Jan Schneider]

Zitat von Atif Ghaffar <aghaffar@developer.ch>:

> Hi jan,
> 
> 
> Jan Schneider wrote:
> > Looks fine by me though I think it should replace the old trailer.txt.
> 
> I dont understand it.
> Can you please explain.
> 
> The first example in conf.php modifies the trailer recieved while
> the second example just ignores the trailer and gets a new one from LDAP.
> 
> The only thing where the second example will not work is if there is no 
> trailer.txt file or if it is not readable ( check in compose.php). This 
> can be changed  if you feel comfortable with it.

IMO, we should drop the old trailer.txt if we have a hook for trailers
because it might be confusing for administrators if there are two places
where a trailer might come from. And what now is done in trailer.txt can
also be done in the hook without any loss of functionality.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft