[imp] IMAP ACLs [PATCH]

[Chris Hastie]

On Tue, 4 Feb 2003, Chuck Hagenbuch <chuck at horde.org> wrote
>Quoting Chris Hastie <lists at oak-wood.co.uk>:
>
>> if (preg_match("/\W/",$pass)) {
>>      $pass = addcslashes($pass, '"\\');
>>      $pass = '"'.$pass.'"';
>> }
>
>You need to read docs/CODING_STANDARDS. This block should look like:
>
>if (preg_match('/\W/', $pass)) {
>    $pass = addslashes($pass, '"\\');
>    $pass = '"' . $pass . '"';
>}
>
I read it. I just re-read it twice. The only differences I can see 
between your block and mine is the spaces after '.' and ',' characters, 
the use of single rather than double quotes and addslashes() rather than 
addcslashes(). I can't find anything about these points in 
docs/CODING_STANDARDS.

Not that I disagree that the spaces make it easier to read or that 
addslashes may be a better choice, but your curt criticism appears not 
to be justified on the basis on which you make it. Nor would does your 
helpful suggestion actually help very much.

Furthermore, addslashes takes only one argument. My code may look 
uglier, but at least it doesn't throw a warning :) (And I did manage to 
find something in docs/CODING_STANDARDS about that...)
-- 
Chris Hastie