[imp] IMAP ACLs [PATCH]

[Eric Rostetter]

Quoting Chris Hastie <lists at oak-wood.co.uk>:

> I read it. I just re-read it twice. The only differences I can see
> between your block and mine is the spaces after '.' and ',' characters,
> the use of single rather than double quotes and addslashes() rather than
> addcslashes(). I can't find anything about these points in
> docs/CODING_STANDARDS.

Using latest CVS HEAD of CODING_STANDARDS:

  Functions should be called with no spaces between the function name,
  the opening parenthesis, and the first parameter; spaces between commas
  and each parameter, and no space between the last parameter, the
  closing parenthesis, and the semicolon. Here's an example:

You are right that the single/double quote isn't in there.  The "dot"
spacing isn't directly addressed, only be example.

Adding a section about single vs double quote would be good.  Maybe I'll
get to it...

> Not that I disagree that the spaces make it easier to read or that
> addslashes may be a better choice, but your curt criticism appears not
> to be justified on the basis on which you make it. Nor would does your
> helpful suggestion actually help very much.

Well, 1 out of 3 are in there.  Another by example, but not mentioned.
The last (quotes) should be but isn't.

-- 
Eric Rostetter
The Department of Physics
The University of Texas at Austin

Why get even? Get odd!