[imp] PATCH: IMP_ACL_rfc2086 - things I learnt yesterday!

[Chris Hastie]

On Wed, 5 Feb 2003, Jan Schneider <jan at horde.org> wrote
>Zitat von Chris Hastie <lists at oak-wood.co.uk>:
>> >
>> I plan on turning my brain on later :(
>>
>> Here we go again...
>
>Looks much better now. Committed, thanks.

Jan

There was method in my madness re no '@' in front of imap_setacl(). If 
you suppress error reporting using the '@', imap_errors() does not 
return any errors.

Thus with the current HEAD, if I try to change permissions on a folder 
which I don't have the 'a' right to, instead of getting a neat Horde 
warning telling me permission was denied I now get an ugly PHP warning 
about invalid arguments to foreach at line 97, and a load of 'could not 
send header' stuff.

Patch attached.
-- 
Chris Hastie
-------------- next part --------------
--- imp/lib/ACL/rfc2086.php,v 1.5
+++ imp/lib/ACL/rfc2086.php	Thu Feb  6 09:23:38 2003
@@ -90,7 +90,7 @@
                 $acl_str .= $key;
             }
         }
-        $result = @imap_setacl($imp['stream'], $folder, $share_user, $acl_str);
+        $result = imap_setacl($imp['stream'], $folder, $share_user, $acl_str);
 
         if (!$result) {
             $errors = imap_errors();