[imp] Colours and Legend

[Son Truong]

Hello Chuck,

Here's the new version of legend.inc as a patch file
(using 'diff -p --unified=0 legend.inc legend.inc.new' - I don't know
how to create a patch file for submission to the Horde Project).
The legend.inc was downloaded from CVS version 1.11.2.3.

The changes includes the addition of the Multipart/Aternative icon
and other code clean up for consistency.

How do I go about submitting a theme to HEAD?

Regards,
Son

Chuck Hagenbuch wrote:

> Quoting Son Truong <svt at st-andrews.ac.uk>:
>
> > Attached in a copy of the legend.inc from horde/imp/templates/mailbox/
> > directory. This puts the icons over the pastel panels, and in addition
> > puts the personal icon and attachment icon on the legend too.
>
> Cleaned up to follow CODING_STANDARDS, use Horde::img(), be XHTML-compliant,
> and committed to HEAD, thanks. Please send patches in the future, though,
> as well as the issues that I addressed/cleaned up.
>
> > One question is what does the 'alternate.gif' denote? I assumed it was to
> > denote a message in pure html format but after sending myself a few of
> > those the icon did not appear. However, I received a junk email today
> > that was flagged with the alternate icon. Could some tell me what this
> > suppose to denote? [see mailbox.jpg, first message]
>
> That there are alternate versions of the same content in the message.
> (multipart/alternative).
>
> > This leads on to; why does html messages denote themselves as
> > messages with an attachment?
>
> Because they have non text/plain parts - i.e., attachments.
>
> > Is there a facility to turn on html
> > messages flagging as with attachments
> > ($conf['mailbox']['show_attachments']=true)?
>
> No.
>
> > As regards to the dark colour issues with colour blind users, I have
> > created a horde/imp theme which gives a light background similar to the
> > 'blue' theme by Atif Ghaffar. Attached it the horde/config/html.php.
>
> You could submit this as a theme for HEAD, definitely.
>
> -chuck
>
> --
> Charles Hagenbuch, <chuck at horde.org>
> The alligators were there, too, in a bathtub inside the house.
>
> --
> IMP mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: imp-unsubscribe at lists.horde.org

--
Son V Truong * Systems Programmer
IT Services * University of St Andrews
svt at st-andrews.ac.uk * 01334 462373

-------------- next part --------------
--- legend.inc	Wed Jun 18 11:18:22 2003
+++ legend.inc.new	Wed Jun 18 11:54:49 2003
@@ -16 +16 @@
-  <td width="15" class="draft" align="right"><?php echo Horde::img('draft.gif') ?></td>
+  <td width="15" class="draft" align="center"><?php echo Horde::img('draft.gif') ?></td>
@@ -18 +18 @@
-  <td width="15" class="personal" align="right"><?php echo Horde::img('personal.gif') ?></td>
+  <td width="15" class="personal" align="center"><?php echo Horde::img('personal.gif') ?></td>
@@ -22 +22 @@ if ($conf['mailbox']['show_attachments']
-    echo '<td width="15" class="text" align="middle">' . Horde::img('attachment.gif') . '</td>';
+    echo '<td width="15" class="text" align="center">' . Horde::img('attachment.gif') . '</td>';
@@ -25 +25,3 @@ if ($conf['mailbox']['show_attachments']
-    ?>
+?>
+  <td width="15" class="multialt" align="center"><?php echo Horde::img('alternative.gif') ?></td>
+  <td width="60" class="legend"><?php echo _("Multi/Alt") ?></td>