[imp] problems with some types of multipart attachments

[Ben Poliakoff]

* Michael M Slusarz <slusarz at mail.curecanti.org> [041031 23:50]:
> Quoting Ben Poliakoff <benp at reed.edu>:
> 
> >* Michael M Slusarz <slusarz at mail.curecanti.org> [041028 17:05]:
> >>>
> >>>Does anyone have any idea why the "index" and "mailbox" arguments might
> >>>be missing when viewing these multipart MIME messages?
> >>
> >>Because, for embedded MIME parts, the 'index' and 'mailbox' doesn't
> >>exist as the
> >>MIME part exists entirely independent of the underlying IMAP message data.
> >>
> >>I've moved an overzealous empty $index check to the correct position in
> >>view.php
> >>so this should be working again.
> >>
> >
> >Cool, that certainly seems to fix all of the issues with
> >multipart/signed MIME messages!  It also fixes some of the issues with
> >multipart/appledouble MIME messages, but not all.
> >
> >In a nutshell when the appledouble viewer is called in a "popup_view"
> >context it uses the wrong "mimecache" when it generates the URL for the
> >data fork.
...snip...snip...
>
> This should be fixed now (the problem was that, in the popup window
> case, the session was being set as readonly so the mimecache was not
> being updated).
>
> michael

Fantastic!  I just did a cvs update of one of my imp installations and
I'm happy to report that this issue is now resolved.  This is very much
appreciated.

I do have one last question regarding the treatment of
multipart/appledouble messages.  Wouldn't it be desireable to force
"inline" display of multipart/appledouble messages so that the
appledouble viewer was only invoked in the main message view window?

The appledouble viewer is invoked in the "popup_view" if the outermost
part of the multipart/appledouble message has a content-disposition
header value of "attachment".

But we don't need to be too concerned about the content-disposition of
the outermost part of a multipart/appledouble message, the appledouble
viewer does a great job of displaying links to the inner parts
of the message (and for those parts, we *are* concerned with the
content-disposition).

Would it be possible to force such behavior?  It seems like it might be
less confusing for the users if the appledouble viewer were always
called in the main message window rather than sometimes showing up in
the "popup_view".

Thanks for your consideration.  And many thanks for all of the work that
has gone into this project in general.

Ben