[imp] Problem encoding in the subject

Patrick Boutilier boutilpj at ednet.ns.ca
Thu Mar 1 13:49:22 PST 2007


Patrick Boutilier wrote:
<snip>

> 
> Yes the fr_FR locale is installed. I have tracked down the problem to 
> the fact that $prefs->getValue('attrib_text') returns "Patrick Boutilier 
> <boutilpj at ednet.ns.ca> a écrit :" instead of "Patrick Boutilier 
> <boutilpj at ednet.ns.ca> a écrit :" (french translation of "Quoting %f:")
> 
> I noticed that the CVS version didn't have this problem so I created 
> this little patch for IMP 4.1.3 based on the CVS code:
> 
> 
> --- horde/lib/Horde/Prefs.php.orig      2006-08-17 10:27:43.000000000 -0300
> +++ horde/lib/Horde/Prefs.php   2007-03-01 14:01:52.000000000 -0400
> @@ -324,11 +324,23 @@
>              $charset = NLS::getCharset();
>          }
> 
> -        return (isset($this->_prefs[$pref]['v'])) ?
> -            ($convert ?
> -             $this->convertFromDriver($this->_prefs[$pref]['v'], 
> $charset) :
> -             $this->_prefs[$pref]['v']) :
> -            null;
> +        if (isset($this->_prefs[$pref]['v'])) {
> +            if ($convert) {
> +                if ($this->isDefault($pref)) {
> +                    /* Default values have the current UI charset. */
> +                    $value = 
> String::convertCharset($this->_prefs[$pref]['v'], NLS::getCharset(), 
> $charset);
> +                } else {
> +                    /* Stored values have the backend charset. */
> +                    $value = 
> $this->convertFromDriver($this->_prefs[$pref]['v'], $charset);
> +                }
> +            } else {
> +                $value = $this->_prefs[$pref]['v'];
> +            }
> +        } else {
> +            $value = null;
> +        }
> +
> +        return $value;
>      }
> 
>      function __get($name)

Of course this fix is already in Horde 3.1.4-rc1 :-)


More information about the imp mailing list