[imp] Feature Request.

[Andrew Morgan]

On Fri, 20 Apr 2007, Anant Athavale wrote:

> Dear Andrew,
>
> If it is so simple, please let me know the modifications and send me the diff 
> file.
>
> TIA
>
> Regards,
> Anant.
>
>
> Quoting Andrew Morgan <morgan at orst.edu>:
>
>> On Thu, 19 Apr 2007, Anant Athavale wrote:
>> 
>>> Quoting Andrew Morgan <morgan at orst.edu>:
>>> 
>>>> On Wed, 18 Apr 2007, Anant Athavale wrote:
>>>> 
>>>>> The problem with sizelimit 0 is, in Compose->Address Book->LDAP
>>>>> Address Book search for blank returns all the e-mail addresses.  I do
>>>>> not want a blank search to be allowed.  For that, Jan suggested to try
>>>>> setting browse = false.  As per the comments defined for browse,
>>>>> setting it false, should not allow for blank search, but it does
>>>>> search and lists all e-mail addresses.
>>>>> 
>>>>> If you need any more clarifications, please let me know.
>>>> 
>>>> What you describe is exactly how it works.  I have exactly the same
>>>> issue here at OSU.  Our directory server will only return 200 entries
>>>> at a time, and I also set the sizelimit to 200 in my sources file
>>>> (redundant, but for completeness sake).
>>>> 
>>>> I am a little confused by part of what you say...  You would like users
>>>> to be able to browse (list all entries) from within Turba itself, but
>>>> you do NOT want a blank search in IMP's address book tool to return all
>>>> entries?
>>> 
>>> Yes. I would like the users to see all the Addresses in Turba.   From 
>>> here, they can not send mail to all at a time.  But, they can,  if they 
>>> want, if they create contact list using LDAP address book.   But, chances 
>>> are less. But, I don't want blank search for Address  Book to work during 
>>> compose.
>> 
>> I think it would be pretty easy to hack imp/contacts.php to skip the
>> search if $search is an empty array.  If you want it on the TODO list
>> for the Horde folks, you should probably file a bug.  :)
>>
>> 	Andy
>
>
>
> Regards,
>
> Anant Athavale.

See the attached patch.  You'll need to modify it if your ldap source is 
not named "localldap".

 	Andy
-------------- next part --------------
--- contacts.php.orig	2007-01-02 05:54:54.000000000 -0800
+++ contacts.php	2007-04-20 13:03:31.000000000 -0700
@@ -52,7 +52,10 @@
 
 $results = array();
 if (Util::getFormData('searched') || $prefs->getValue('display_contact')) {
-    $results = $registry->call('contacts/search', $apiargs);
+    // Don't process blank searches against the localldap source
+    if (! ($source == 'localldap' && $search == '') ) {
+        $results = $registry->call('contacts/search', $apiargs);
+    }
 }
 
 /* The results list returns an array for each source searched - at least