[imp] IMP 5 Virtual trash

[Tony Bunce]

Is there a trick to getting virtual trash working in IMP 5?  I am trying to migrate an old 4.x install to a new IMP 5 install but so far I can't get the virtual trash to work out of the box.

I'm not sure if this is a bug or if I am doing something wrong.  I ran into 2 main issues:
1 - With vtrash enabled messages were being purged immediately via IMAP instead of being marked as deleted
2 - Once issue 1 was resolved messages were marked as deleted but they were being shown in their original folder and the Virtual trash was empty.

I make a few changes to the source and everything appears to be working as I expect it to but I'm not sure if I'm doing something wrong or if I am hitting a bug.

Anyone using IMP 5 with the Virtual Trash and have it working without making any changes to the source?  Did you have to do anything special?

Here are the changes I made:
Patch file vs 5.0.23:
https://gist.github.com/3835398

Diff vs master:
https://github.com/TonyBunce/horde/compare/horde:master...TonyBunce:master

Thanks!
-Tony