[imp] 6.1.0-git

[Simon B]

On 17 May 2013 09:22, Simon B <simon.buongiorno at gmail.com> wrote:
> On 16 May 2013 19:38, Michael M Slusarz <slusarz at horde.org> wrote:
>> Quoting Simon Brereton <simon.buongiorno at gmail.com>:
>>
>>> On 10 April 2013 12:02, Simon Brereton <simon.buongiorno at gmail.com> wrote:
>>>>
>>>> On 10 April 2013 11:39, Nuno Lopes <nuno.lopes at portugalmail.pt> wrote:
>>>>>
>>>>> Hi Simon,
>>>>>      from what I understand the funcionality hasn't gone away, it has
>>>>> been
>>>>> moved to another configuration. You can read that in the upgrading
>>>>> documentation:
>>>>>
>>>>> The following spam-reporting options have been removed and can now be
>>>>> configured per-backend in ``config/backends.local.php``::
>>>>>
>>>>>    $conf['notspam']['email']
>>>>>    $conf['notspam']['email_format']  ...
>>>>> https://github.com/horde/horde/blob/master/imp/docs/UPGRADING  hope this
>>>>> helps, -- Nuno Lopes
>>>>
>>>>
>>>> So I see.  I'd still feel better knowing the rationale for these changes.
>>
>>
>> Because it made zero sense to set a one-size-fits-all spam reporting
>> solution in the configuration file.  What happens if you have two servers
>> listed in backends.php, your local IMAP server and Gmail?  I'm about 102%
>> sure that you do not want the same spam reporting configuration for both of
>> these servers.
>>
>>>> Not that my userbase uses this feature, but I can this will cause some
>>>> confusion too..
>>>>
>>>> The following options have been removed::
>>>>
>>>>    $conf['compose']['link_all_attachments']
>>>
>>>
>>> So, I've added these configurations items to
>>> imp/config/backends.local.php and still I have no report as spam
>>> button in my mail interface anymore.
>>
>>
>> And you added them in the correct format, as described in
>> config/backends.php?  You can't just copy/paste the old lines from conf.php,
>> if that's what you did.
>
> Interesting - the old way was of course much easier to configure :)
>
> Spam reporting is done (here) via spamcop, so that's easy - it's just
> an email address.
>
> Innocent reporting is a little trickier.  How does one move it back to
> the Inbox?  From the docs, I have:
>
>
>  *     - email: (string) The e-mail address to use for reporting
>  *     - email_format: (string) Either 'digest' or 'redirect'.
>  *       - digest: [DEFAULT; RECOMMENDED] Packages the raw data of all
>  *                 messages reported by the user in their marking action and
>  *                 sends to the reporting e-mail address ('email' option) in a
>  *                 single multipart/digest message.
>  *       - redirect: Redirects the message to the reporting e-mail address
>  *                   ('email' option). Note that this alters the original
>  *                   message's headers and may break embedded spam reporting
>  *                   signature information contained in the original message.
>  *     - program: (string) An external program to report the spam message to.
>  *                Messages will be reported to the program via standard input.
>
> My original settings for this were..
>
> $conf['notspam']['spamfolder'] = true;
> $conf['notspam']['email_format'] = 'digest';
> $conf['notspam']['program'] = '/usr/bin/spamassassin -k %u';
> $conf['notspam']['reporting'] = true;
>
> do I just leave email commented?  or is it %u?  Or does the
> spamassassin take care of that?
>

Now I have a white screen and these errors in the apache.log

[Fri May 17 07:40:59 2013] [error] [client 195.233.250.6] PHP Parse
error:  syntax error, unexpected ',' in
/usr/share/git-horde5/imp/config/backends.local.php on line 69
[Fri May 17 07:43:21 2013] [error] [client 195.233.250.6] PHP Parse
error:  syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting
')' in /usr/share/git-horde5/imp/config/backends.local.php on line 70
[Fri May 17 07:44:28 2013] [error] [client 195.233.250.6] PHP Parse
error:  syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in
/usr/share/git-horde5/imp/config/backends.local.php on line 70


 60     'special_mboxes' => array(
 61          IMP_Mailbox::MBOX_DRAFTS => 'Drafts',
 62          IMP_Mailbox::MBOX_SENT => 'Sent',
 63          IMP_Mailbox::MBOX_SPAM => 'Spam',
 64     //     IMP_Mailbox::MBOX_TEMPLATES => 'Templates',
 65          IMP_Mailbox::MBOX_TRASH => 'Trash',
 66     //     IMP_Mailbox::MBOX_USERSPECIAL => array(
 67     //         'Example' => _("Example Special Mailbox")
 68          )
 69     )
 70     'autocreate_special' => 'true',
 71 );


first I commented out the ), that was on line 69, but it still
complained, so I just removed the , and then the error moved to line
70, which had true and not 'true', but not it's still complaining and
I know not why.

Any ideas?

Thanks.

Simon