[imp] Message content not displayed after upgrade to PHP 7.3

[Michael J Rubinsky]

Quoting Arjen de Korte <build+horde at de-korte.org>:

> Citeren Arjen de Korte <build+horde at de-korte.org>:
>
>> Citeren Arjen de Korte <build+horde at de-korte.org>:
>>
>>> Just a heads-up for those that what to upgrade to PHP 7.3: it  
>>> seems like there are some incompatibilities with Horde (master) in  
>>> handling regular expressions.
>>>
>>> Some (but not all) messages will not display content.
>
> It looks like HTML mail is displayed correctly and text-only ones don't.
>
>>> The following is logged for each message:
>>>
>>> 2018-12-25T12:47:27+01:00 WARN: horde [imp] PHP ERROR:  
>>> preg_replace_callback(
>>> ): Compilation failed: invalid range in character class at offset  
>>> 68 [pid 207
>>> 6 on line 99 of "/usr/share/php7/PEAR/Horde/Text/Filter.php"]
>>> 2018-12-25T12:47:27+01:00 WARN: horde [imp] PHP ERROR:  
>>> preg_replace_callback(
>>> ): Compilation failed: invalid range in character class at offset  
>>> 649 [pid 20
>>> 76 on line 99 of "/usr/share/php7/PEAR/Horde/Text/Filter.php"]
>>>
>>> This may be due to the stricter interpretation of character ranges  
>>> in classes.
>>
>> Note that the message content is available. I can reply to such a  
>> message (like the one quoted above) just fine. So the trouble seems  
>> to be in rendering messages, rather than grabbing them from the  
>> IMAP server.

Any chance you can get a stack trace to see where the regexp is coming  
from? I can't reproduce this on a fresh VM I spun up with php 7.3 and  
current git master.

I did find some regexps that needed to be fixed, but I dont' think  
those are called when just displaying an email. See:  
https://github.com/horde/imp/commit/5186ad002b0809960fd6096a2ca85ab8d2aab888

Also, please make sure you are up to date with git on *all* packages.  
I know there were a few similar fixes not *too* long ago in some other  
packages, like Text_Filter.


-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 9272 bytes
Desc: PGP Public Key
URL: <https://lists.horde.org/archives/imp/attachments/20181227/eb7fcf7c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 821 bytes
Desc: PGP Digital Signature
URL: <https://lists.horde.org/archives/imp/attachments/20181227/eb7fcf7c/attachment-0001.bin>