[ingo] Re: [dev] Re: [cvs] commit: ingo/lib/Script imap.php

[Jan Schneider]

Zitat von Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at bigworm.colorado.edu>:
>
> > This leaves only the matching rules that need to be addressed.  Right
> > now,
> > they live in config/tests.php.  I don't see any need for them to be in
> a
> > configurable file - since they are entirely dependent on the script
> > backend
> > (e.g. the IMAP driver is not going to implement 'greater than' or 'less
> > than' - at least to begin with).  I would like to convert these tests
> to
> > constants also and remove the tests.php file.
> >
> > Any reason for not doing this?  (Speak now or forever hold your peace
> :)
> > ).
>
> Yes. I extracted them from the libraries into a config file mostly
> because
> of the $fields array. With Sieve you could add any possible header to
> this
> array, so each time someone wants a new header field in their drop down
> list, they had to hack the core code. Not good.
>
> I'm not sure anymore why I put the tests arrays in there. Probably
> because
> it was as easy to add a new test to Sieve as adding a new header field.

This all might become obsolete btw, as soon as we are able to enter the
header to test in a text field in Ingo.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft