[kronolith] kronolith and oci8 - success!

[Chuck Hagenbuch]

Quoting Liam Hoekenga <liamr@umich.edu>:

> I think I've suceeded in making kronolith work with oracle 8.

Thanks for all of this work, Liam - as I had mentioned earlier, I installed 
Oracle on my laptop recently (ouch, I know, but hey, it works), and I've 
finally gotten around to looking at what you've done and getting stuff 
committed.

I added a kronolith.oracle.sql table creation script; it works here, but 
can you take a look at it and see if it matches what you're using? Or if 
you have any suggestions on it.

Second, about the date format stuff, I added a switch to the Kronolith SQL 
driver that runs the date format query in Kronolith's _connect() method. 
I'm okay with having the db-specific query there, especially since it's 
just a query that can be run through DB::query() and doesn't require any db-
specific function calls.

> - Do the queries really have to be down to the millisecond?

No. :) I've removed this too.

> - All of the horde modules I've played with to date have debugging code
> in them.  Kronolith doesn't.  Not a Horde::logMessage to be seen anywhere.

Yeah, that wasn't so good. I've added a logMessage() before every call to 
_db->query(). There are a few other places we can add logging, but this is 
at least better.

>   When I added them to the sql.php file (basically lifting the one from
>   Turba), I also tried to standarize the variable names with those found
>   in Turba's sql.php and Horde's lib/Prefs/sql.php ($query for the $query 
>   instead of $q, $results for results instead of $qr, etc).

A patch to clean this up would be fine - I mostly didn't touch that. That 
code could get a lot cleaner.

Let me know if what's in CVS works for you!

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"What was and what may be, lie, like children whose faces we cannot see, in 
the arms of silence. All we ever have is here, now." - Ursula K. Le Guin