[kronolith] Kronolith 4.1.4: Emailed iTip and Agenda's contain links that don't work properly

[Jan Schneider]

Zitat von Anthony Messina <amessina at messinet.com>:

> On Wednesday, January 15, 2014 02:55:27 PM Jan Schneider wrote:
>> Zitat von Anthony Messina <amessina at messinet.com>:
>> > Hello, I have a very new Horde installation configured at
>> > example.com/horde and I am using Kronolith.  I am seeing the
>> > following two issues and am not certain if they are specific to my
>> > (mis)configuration.  Any guidance would be appreciated.  Thanks.  -A
>> >
>> > 1. iTip responses
>> > When a user receives an email with an event invitation in a client
>> > that doesn't support iTip, they click on the  "accept" link which
>> > brings them to a page (attend.php) that says the following.  I can
>> > see from looking at attend.php that the GET request for "i" fails as
>> > there is no "i" data in the requested URL from the email.
>> >
>> > busy
>> >
>> >  No from address provided.
>>
>> This is from event updates being sent by email with no from address
>> being provided in some user's identity.
>
> I do have my from_addr set in my identity, which is pulled in from LDAP via
> the preauthenticate hook upon login to Horde.  I have confirmed this  
> by adding
>
> $notification->push(sprintf(_("Your identity is %s"), $ident->  
> getValue('from_addr')));
>
> to the sendITipNotifications function in Kronolith.php and I see the
> notification in the corner detailing my proper email address when I create an
> event with attendees.

It doesn't matter if YOU have a from address set.

> Looking at the following further down in the sendITipNotifications  
> function in
> Kronolith.php, I do not see where the "i" is inserted into the URL.

It's not needed.

> if ($action == self::ITIP_REQUEST) {
>     $attend_link = Horde::url('attend.php', true, -1)
>         ->add(array('c' => $event->calendar,
>                     'e' => $event->id,
>                     'u' => $email));
>     $view->linkAccept    = (string)$attend_link->add('a', 'accept');
>     $view->linkTentative = (string)$attend_link->add('a', 'tentative');
>     $view->linkDecline   = (string)$attend_link->add('a', 'decline');
> }
>
>
> Oddly enough, I have copied and pasted the emailed iTip URL from an attendee
> into the browser.  IF the user IS logged into Horde, they get "You have
> successfully accepted attendence to this event."  IF the user IS NOT logged
> into Horde, they get "No from address provided."
>
> It seems strange to me that an attendee would need to be logged into Horde to
> indicate acceptance, since 1) they may not have a Horde account, and 2) even
> so, they are not prompted to login when accessing the accept, decline, etc.
> iTip URLs.
>
> -A


-- 
Jan Schneider
The Horde Project
http://www.horde.org/
https://www.facebook.com/hordeproject