[kronolith] Changing event start date/time

[Philipp Faeustlin]

Am 14.04.2016 um 15:11 schrieb Michael J Rubinsky:
>
> Quoting Test <philipp.faeustlin at uni-hohenheim.de>:
>
>> Am 13.04.2016 um 14:37 schrieb Michael J Rubinsky:
>>>
>>> Quoting Philipp Faeustlin <Philipp.Faeustlin at uni-hohenheim.de>:
>>>
>>>> Hi,
>>>>
>>>> I think found an fault or at least an unwanted behaviour.
>>>>
>>>> When editing an existing event start to empty fields and saving that
>>>> event.
>>>>
>>>> The results is an event that starts probably at day 0 in year 0. I
>>>> didn't scroll back that far, but the database entry for that event
>>>> says event_start = "0000-00-00 00:00:00".
>>>> The problem now is, as user your don't have a possibility to resolve
>>>> your mistake, because you're unable to edit or remove this event.
>>>>
>>>> As admin I had to change the event_start on database layer, to be able
>>>> to edit the event again.
>>>>
>>>> I think it shouldn't be possible to save an event with empty date, or
>>>> it should automatically save an working date (for example midnight
>>>> same day).
>>>>
>>>> Regards
>>>>
>>>> Philipp
>>>>
>>>> PS.: Tested with current firefox, chrome and up-to-date version of
>>>> horde.
>>>
>>> Can you describe how you are emptying the event start field(s)? We
>>> already have code in place that prevents saving the event when the date
>>> field doesn't validate. I can't reproduce this locally - I get the
>>> expected error message in a notification bubble when trying to save.
>>>
>>>
>> In the edit event window I remove the content of "From","at" per
>> keyboard. On my system there is no notification bubble.
>>
>> How is the date field validated?
>
> It's validated in javascript when the field loses focus and checked
> again when the event is saved. If the form field is not parse-able into
> a date value, the event is not allowed to be saved. I just tested this
> again on the demo site at demo.horde.org and it works as expected.

I can reproduce it, also on the demo site.
I tested it with user "demo".
I added a new calender "ChangingEvent" in this calendar I add an event 
"Event unable to change" with empty startdate and starttime.
I think you can see the result.
Getting rid of this event is only possible on database level or by 
deleting the whole calender.
>
> Do you see any javascript errors?
>
Firebug "Script" tells me
Error: "throw $continue" is deprecated, use "return" instead
prototype.js?v=8c6450e219c8a631b6b945cc73e9158e()prototy...3e9158e 
(Zeile 7306)

And

HordePopup
	Object { popup_block_text="A popup window could not...may be blocking 
popups.",  popup=function(),  iePopupOnload=function()}

I think perhaps some bocked Popups, but if the popups doesn't work the 
event shouldn't be saved or checked twice.

>
>> What is the intended structure on database layer for "event_start" and
>> "event_end"?
>
> It's a datetime value.
>
>>
>> --
>> Philipp Fäustlin
>> Universität Hohenheim
>> Kommunikations-, Informations- und Medienzentrum (630)
>> IT-Dienste | Abt. Kommunikation, E-Learning u. Print | Mail
>>
>> Schloss, Westhof Süd | 70599 Stuttgart
>> Tel.: +49 711 459-22838 | Fax: +49 711 459-23449
>> https://kim.uni-hohenheim.de/
>> --
>> kronolith mailing list
>> Frequently Asked Questions: http://wiki.horde.org/FAQ
>> To unsubscribe, mail: kronolith-unsubscribe at lists.horde.org
>
>
>
>
>