[sam] Re: [cvs] commit: sam whitelist.php sam/docs CHANGES sam/lib SAM.php sam/lib/Driver sql.php sam/templates/menu menu.inc sam/templates/whitelist body.inc

[Chuck Hagenbuch]

Quoting "Marc G. Fournier" <scrappy@hub.org>:

> 'K, you'll have to enlight me on this one ... what do you mean by the
> SpamAssassin username is not necessarily created by stripping
> @domain.com?
> I thought it was always *just* the username component, and it ignored the
> domain ... or am I mis-understanding what you are saying here?

What if it's a vdomain setup, and username@domain.com is the actual 
username? Then you've broken that site, as well.

> As for 'alot of horde setups' ... my guess is that chris is doing a split
> based on @, with the user component being on the left, domain on the
> right
> ... so if there is no @, then it won't make a difference ...

... but what if the username has to be translated some other way? And it's 
innefficient to do it if it's not necessary, but most of all, it's just not 
an assumption that that driver should be making. It encapsulates knowledge 
of and assumptions about the rest of the system which aren't necessarily 
valid and which shouldn't be made there.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"What was and what may be, lie, like children whose faces we cannot see, in 
the arms of silence. All we ever have is here, now." - Ursula K. Le Guin