[sork] [patch] fix the "cannot add header information" warning bug in forwards-2.2

Wenzhuo Zhang wenzhuo at zhmail.com
Tue Oct 14 01:22:28 PDT 2003


Hi,

When accessed from Internet Expolorer, the forwards main page would
issue the following warnings:

Warning: Cannot add header information - headers already sent by (output
started at /var/www/html/horde/templates/javascript/open_help_win.js:1)
in /var/ww/html/horde/forwards/templates/common-header.inc on line 3

Warning: Cannot add header information - headers already sent by (output
started at /var/www/html/horde/templates/javascript/open_help_win.js:1)
in /var/ww/html/horde/forwards/templates/common-header.inc on line 4

See attached screenshot. - The problem does not show up when accessed by
Mozilla.

The attached tiny patch fixed the problem by loading common-header.inc
first.

The bug is still present in the RELENG_2 branch. The HEAD branch
shouldn't have the problem.

Best regards,

-- 
Wenzhuo
  GnuPG Key ID 0xBA586A68
  Key fingerprint = 89C7 C6DE D956 F978 3F12  A8AF 5847 F840 BA58 6A68
-------------- next part --------------
--- horde.orig/forwards/main.php	2003-01-20 13:30:42.000000000 +0800
+++ horde/forwards/main.php	2003-10-14 23:52:43.000000000 +0800
@@ -89,8 +89,8 @@
                     HORDE_ERROR);
 }
 
-    include_once $registry->getTemplatePath('horde') . '/javascript/open_help_win.js';
     require $registry->getTemplatePath() . '/common-header.inc';
+    include_once $registry->getTemplatePath('horde') . '/javascript/open_help_win.js';
     require $registry->getFileRoot() . '/status.php';
     require $registry->getTemplatePath() . '/main/javascript.inc';
     require $registry->getTemplatePath() . '/main/main.inc';
-------------- next part --------------
A non-text attachment was scrubbed...
Name: forwards-warning.gif
Type: image/gif
Size: 5699 bytes
Desc: not available
Url : http://lists.horde.org/archives/sork/attachments/20031014/60aecf99/forwards-warning.gif


More information about the sork mailing list