[sork] Patch for vacation forwards-driver (.forward-parser)

Espen Jürgensen espen at hhkol.dk
Mon May 3 05:13:17 PDT 2004


Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Espen Jürgensen <espen at hhkol.dk>:
> 
> > However, there are some problems related to the way _getUserDetails
> > exits, and these problems affect the parser. Currently, it seems like it
> > is difficult to trigger an error. Even ftp errors do not get shown. I
> > believe the problem is related to the structure of the driver, where
> > _getUserDetails gets called twice. But I haven't examined these issues
> > thoroughly, since they are outside the scope of this patch.
> 
> If $this->_details is set, then it'll just be returned, so you can set it
> to
> false or an empty array or what have you.
> 

I have taken an extra look at how to trigger an error message from 
getUserDetails (in the Vacation module), and it seems to be a bit tricky.

The whole design around Driver.php and getUserDetails doesn't really seem to 
allow an error to be triggered - or am I mistaken? It seems a bit odd, since 
there is plenty of error handling inside getUserDetails, but errors just won't 
trigger any message.

I might be able to hack something together, which will show errors from just 
the parser, but it would be quite ugly.

So my question is, if there is any general plan/idea on how to fix this?

Regards,
Espen

PS: The above applies to a version of vacation which is a couple of weeks old. 
If it has already been fixed then forgive me. Our testing server has been 
of the internet for a while.


More information about the sork mailing list