[sork] [accounts] Update of accounts module

Roel Gloudemans roel at gloudemans.info
Mon Aug 9 10:48:18 PDT 2004


Hi Jan,

>> Error reporting is also brushed up. The patches are included in the 
>> mail. Please
>> tell me what you think of it. This is my first real work on a horde module
>> (however small), so expect me to violate the coding standards.
>
> Indeed, please fix the indention (4 chars, no tabs) and the curly braces (on
> the same line, only after function headers on the next).

Ok, I'll do that

> I didn't look at the whole code, only at your patches. But wouldn't it
> perhaps make sense to use the account data only internally inside the
> drivers instead of passing them in the $information variable around? The
> getAccount() function could be made private and keep the account data in a
> static variable.

Yes that sounds better. I'll do that also.

I'll post revised patches as soon as possible (my) tomorrow evening or
wednesday.

The patch I've mave in the LDAP passwd driver is an add on to this one. 
Did you
see that also?

Thanks for the feedback,
Roel.



More information about the sork mailing list