[sork] Passwd tab sequencing

[Simon Brereton]

On 9 November 2011 10:30, Simon Brereton <simon.brereton at buongiorno.com> wrote:
> On 9 November 2011 08:55, Jan Schneider <jan at horde.org> wrote:
>>
>> Zitat von Simon Brereton <simon.brereton at buongiorno.com>:
>>
>>> Hi
>>>
>>> I have two minor UI suggestions for the passwd module.
>>>
>>> Firstly, the username comes prefilled (if supported), which is nice.
>>> However, if the browser has save the password, this is also
>>> pre-filled.  Whilst this is nice because it means the browser will
>>> request to update the password after a successful change it is also a
>>> danger.  Users who stay logged in can have their password changed
>>> (either maliciously or not) because the authentication is already
>>> there.  It would be better not to pre-fill that field, or other have
>>> some other two-step authentication verification.
>>
>> Like you already said, this is a browser feature.
>
> It's been a long long time since I did any web coding.  But I seem to
> recall (and other sites manage it) that if you rename the password
> field then the browser won't fill it.
>
>>> Secondly, users are capable or and used to using the tab key to move
>>> between form fields.  However, in the passwd module the tab key takes
>>> you to the help icons (which if you have a resolution bigger then
>>> 1024x768) are miles away from what they relate to.
>>>
>>> I would propose therefore to make the tab sequencing..
>>>
>>> Username:
>>> Old password:
>>> New password:
>>> Confirm new password:
>>> Change Password
>>> Reset
>>> Username Help
>>> Old password Help
>>> New password Help
>>> Confirm new password Help
>>
>> Patch?
>
> See above.  I would love to contribute but seriously it would take
> more time for me to fix it than it would for you to build H5.  And
> then you'd still have to fix it.  But I'll take a look :)

Here's a patch.  It correctly changes the tab order (although because
of the way the help icons are built those are moved right to the end
of the sequence.  I'm sure someone with more familiarity or the horde
framework could correct that) for me to be able to move from field to
field and then to submit/reset.

It also stops the password from being loaded with the form - but for
some reason despite the fact that stackoverflow (and mozilla) assured
me it would stop the old password from loading as soon as you tab into
the field it does load.  Still it's a start.  It could also just be my
browser (Firefox on Ubuntu 10.10).

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: passwd.template.index.html.php.patch
Type: application/octet-stream
Size: 3006 bytes
Desc: not available
URL: <http://lists.horde.org/archives/sork/attachments/20111109/6b39daba/attachment.obj>