[sync] SyncML Patch and Seg Fault

[Anthony Mills]

I pretty much hacked the files as best I could to run with a syncml 
client.  It's one thing for them to "complie" and another for them to 
run with actual data.  I fixed some syntax errors, tried to fix some 
broken logic.  I made the wbxml get and send xml files through the 
variables and not streams.  the variables I changed from _var to var are 
public variables that are used in both the decoder (it gets the 
variables) and encoder (it sets them).  My goal was to get the stuff 
working no matter how ugly.  Some things just will not work, the static 
variable is always 0.  Once I knew that it worked, I was going to make 
it cleaner and more straight forward.  You don't have to commit the 
patch, and it might be better if you didn't.  I just wanted the list to 
see it, and to see if there was something just I was just doing blantely 
wrong.  My goal is to finish this part today and start on the SyncML 
portion tonight.  PHP is really hard to use binary data, but I press on.

Thanks,
Anthony

Chuck Hagenbuch wrote:
> Quoting Chuck Hagenbuch <chuck at horde.org>:
> 
> 
>>Can you provide a bit of explanation about the pieces of this patch and what
>>they do? Some of them look weird to me; some of them just add trailing
>>whitespace to the files, and some of them seem to just change private variable
>>names ($_var) to public ($var) (no, that's not enforced, but it's a visual
>>convention to let the programmer know the intention of the variable). So I'd
>>rather not commit this wholesale...
> 
> 
> Also, just so you know, I'm going to try and fix the minor things that are fixed
> in the patch that I can see, so if you update, take out the extra commented
> code/debugging, and the whitespace, you should get a better diff.
> 
> One more note - the patch added an authorize() function to RPC_syncml_wbxml, but
> that class extends the RPC_syncml class, which already provides that method, so
> it isn't needed, unless you're trying to accomplish something else there...
> 
> -chuck
> 
> --
> Charles Hagenbuch, <chuck at horde.org>
> "I'm really... I'm not too fascinated by green food." - Average Joe
>