[sync] Sync of Nokia N70

Chuck Hagenbuch chuck at horde.org
Tue Apr 11 21:45:43 PDT 2006


Quoting Daniel Andersson <horde at addelei.nu>:

> First of all, in XML/WBXML/DTDManager.php I think changes are required
> on either line 39 or line 63. The problem is that when data is stored
> in the array (function registerDTD, line 63), the key is set to
> $publicIdentifier. However when data is looked up in the table
> (function &getInstance, line 39-40) the key is
> strLower($publicIdentifier). I found at least one occation when
> $publicIdentifier was in CAPITALS or SillyCapsed and the lookup thus
> failed. I have no idea about which line should be The Right One to
> change but I do think that one of them should be changed.

This seems straightforward enough; I've committed a change to  
consistently lowercase things.

> Second, in the XML/WBXML/DTD/SyncML.php we execute setCodePage for
> SyncML and MetInf DTD's (lines 75-76 and 79-80). But we don't add
> codepages for the DevInf DTD. I had a call to
> XML_WBXML_DTD->toCodePageURI() where this one was needed and I _guess_
> that we should add this here as well. Or is it that SyncML and MetInf
> should be added in their respective classes but DevInf should only be
> added in it's own? In that case - why this difference. Anyway - when I
> added DevInf here it seemed to go a bit further.

This I don't know offhand. Karsten?

Daniel, if you want to make sure this doesn't get lost, you should  
create a ticket for it on http://bugs.horde.org/ in the Horde  
Framework Packages queue.

Thanks,
-chuck

-- 
"we are plastered to the windshield of the bus that is time." - Chris


More information about the sync mailing list