[turba] Re: LDAP scope
Craig White
craigwhite at azapple.com
Mon Mar 7 12:12:36 PST 2005
--=-7xFuhNQNYl+pWKztw35r
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
On Sat, 2005-03-05 at 00:02 -0500, Chuck Hagenbuch wrote:
> Quoting Craig White <craigwhite at azapple.com>:
>
> > sorry - realize now that I did need to provide diff for current ldap.php
> > after all...it is attached
>
> I've cleaned this up and committed it to both branches. The patch
> against sources.php.dist is broken, though (it's against sources.php
> for starters). Please look over the style and generate one that applies
> cleanly to sources.php.dist.
>
----
OK - think I've got all my issues covered...
cvs diff -u sources.php.dist > turba-sources.php.diff (attached)
I have altered emacs to convert whitespace tabs to spaces and it seems
to work.
I have verified file with od that it is indeed spaces and not tabs.
I have viewed the contribute web page...
http://www.horde.org/source/contribute.php
and the coding standards...
http://cvsweb.horde.org/co.php/horde/docs/CODING_STANDARDS
and will try to incorporate as much of this as I can remember as I go
through it.
I have learned a lot through this process and I thank you for your
patience and educating me - this was obviously a simple patch which you
obviously could do at any point but I think since it was me that was
driving the issue, you have waited for me to finish it.
I look forward to making many more contributions as this was surely a
minor one but I suppose that many have started like this.
Craig
--=-7xFuhNQNYl+pWKztw35r
Content-Disposition: attachment; filename=turba-sources.php.diff
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
A non-text attachment was scrubbed...
Name: turba-sources.php.diff
Type: text/x-patch
Size: 924 bytes
Desc: not available
Url : http://lists.horde.org/archives/turba/attachments/20050307/83ca3214/turba-sources.php.bin
--=-7xFuhNQNYl+pWKztw35r--
More information about the turba
mailing list