[cvs] commit: whups checkout.php common.php diff.php cvs.php whups/lib CVSLib.php whups/lib/CVSLib diff.php whups/templates diff_header.inc diff_request.inc dir_back.inc dir_directory.inc dir_footer.inc dir_header.inc hr_diff_footer.inc ...

[Chuck Hagenbuch]

Quoting avsm@horde.org:

>   Slightly new look as well; it's still ugly, but will improve!

Looks nice!

>   Notice that new base files have been added for diff and checkout, as
>   this cleans up the url handling a fair bit; any objections?

Not at all.

A few minor things:

- Do you _always_ need all of the CVSLib subclasses? Would it make sense to
include_once them when you actually need them?

- All of the other horde apps use $conf['paths'][] for path information, instead
of using a seperate $path variable. Could whups do this as well, so as to not
use as many global variables?

I haven't really looked through everything closely, but it looks pretty good.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"If you can't stand the heat, get out of the chicken!" - Baby Blues